Bump to protobuf==3.18.3 within lbry-sdk repo causes MacOS unit test failures #121

New issue

Open

opened 2023-01-16 22:26:27 +01:00 by moodyjon · 1 comment

moodyjon commented

2023-01-16 22:26:27 +01:00

(Migrated from github.com)

Hub/setup.py protobuf version was bumped in this change:

75d64f9dc6

However, when I try to apply a corresponding change in lbry-sdk/setup.py:

(lbry-venv) swdev1@Jonathans-Mac-mini lbry-sdk % git diff
diff --git a/setup.py b/setup.py
index bd468c687..4c736f646 100644
--- a/setup.py
+++ b/setup.py
@@ -37,7 +37,7 @@ setup(
         'base58==1.0.0',
         'cffi==1.13.2',
         'cryptography==2.5',
-        'protobuf==3.17.2',
+        'protobuf==3.18.3',
         'prometheus_client==0.7.1',
         'ecdsa==0.13.3',
         'pyyaml==5.3.1',
@@ -57,7 +57,7 @@ setup(
             'jsonschema==4.4.0',
         ],
         'hub': [
-            'hub@git+https://github.com/lbryio/hub.git@929448d64bcbe6c5e476757ec78456beaa85e56a'
+            'hub@git+https://github.com/lbryio/hub.git@75d64f9dc6d3b2c913b8b10053bd3589e7a2e8eb'
         ]
     },
     classifiers=[

The MacOS unit tests start to fail:

https://github.com/moodyjon/lbry-sdk/actions/runs/3933945634

I'm uncertain whether this is due to use of "coverage" tool, GitHub CI, or OS/arch issue.

Unit tests work fine when run locally on my machine (MacOS 13.1 / arm64). I have a development branch which was bumped to "protobuf==3.20.1" for other reasons (stringmap_extensions), and it didn't have the same effect of breaking the test.

Hub/setup.py protobuf version was bumped in this change: 75d64f9dc6d3b2c913b8b10053bd3589e7a2e8eb However, when I try to apply a corresponding change in lbry-sdk/setup.py: ``` (lbry-venv) swdev1@Jonathans-Mac-mini lbry-sdk % git diff diff --git a/setup.py b/setup.py index bd468c687..4c736f646 100644 --- a/setup.py +++ b/setup.py @@ -37,7 +37,7 @@ setup( 'base58==1.0.0', 'cffi==1.13.2', 'cryptography==2.5', - 'protobuf==3.17.2', + 'protobuf==3.18.3', 'prometheus_client==0.7.1', 'ecdsa==0.13.3', 'pyyaml==5.3.1', @@ -57,7 +57,7 @@ setup( 'jsonschema==4.4.0', ], 'hub': [ - 'hub@git+https://github.com/lbryio/hub.git@929448d64bcbe6c5e476757ec78456beaa85e56a' + 'hub@git+https://github.com/lbryio/hub.git@75d64f9dc6d3b2c913b8b10053bd3589e7a2e8eb' ] }, classifiers=[ ``` The MacOS unit tests start to fail: https://github.com/moodyjon/lbry-sdk/actions/runs/3933945634 I'm uncertain whether this is due to use of "coverage" tool, GitHub CI, or OS/arch issue. Unit tests work fine when run locally on my machine (MacOS 13.1 / arm64). I have a development branch which was bumped to "protobuf==3.20.1" for other reasons (stringmap_extensions), and it didn't have the same effect of breaking the test.

moodyjon commented

2023-01-16 22:29:30 +01:00

(Migrated from github.com)

This blocks linking to a new version of hub in lbry-sdk/setup.py. I think the change should be reverted, or we go to a higher version of protobuf that does not have the same problem.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/hub#121

No description provided.