LBRYCommunity/lbcd
1
0
Fork 0
Code Issues 17 Pull requests 4 Projects Releases 28 Packages Wiki Activity

Make use of the new size hint functions in btcwire.

Browse source 
This commit changes a couple of sections which deal with large lists of
inventory vectors to use the new size hint functions recently added to
btcwire.  This allows a bit more efficiency since the size of the list is
known up front and we can therefore avoid dynamically growing the backing
array several times.  This also helps avoid a Go bug that leaks memory on
appends and GC churn.
This commit is contained in:
Dave Collins 2014-01-08 17:46:59 -06:00
parent 462bc5a031
commit 3946d84887
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
blockmanager.go
View file

@ -1092,7 +1092,7 @@ func (b *blockManager) handleHeadersMsg(bmsg *headersMsg) {
// fetchHeaderBlocks is creates and sends a request to the syncPeer for // fetchHeaderBlocks is creates and sends a request to the syncPeer for
// the next list of blocks to downloaded. // the next list of blocks to downloaded.
func (b *blockManager) fetchHeaderBlocks() { func (b *blockManager) fetchHeaderBlocks() {
gdmsg := btcwire.NewMsgGetData() gdmsg := btcwire.NewMsgGetDataSizeHint(btcwire.MaxInvPerMsg)
numRequested := 0 numRequested := 0
startBlock := b.startBlock startBlock := b.startBlock
for { for {

6
peer.go
View file

@ -490,9 +490,11 @@ func (p *peer) PushGetHeadersMsg(locator btcchain.BlockLocator) error {
func (p *peer) handleMemPoolMsg(msg *btcwire.MsgMemPool) { func (p *peer) handleMemPoolMsg(msg *btcwire.MsgMemPool) {
// Generate inventory message with the available transactions in the // Generate inventory message with the available transactions in the
// transaction memory pool. Limit it to the max allowed inventory // transaction memory pool. Limit it to the max allowed inventory
// per message. // per message. The the NewMsgInvSizeHint function automatically limits
invMsg := btcwire.NewMsgInv() // the passed hint to the maximum allowed, so it's safe to pass it
// without double checking it here.
hashes := p.server.txMemPool.TxShas() hashes := p.server.txMemPool.TxShas()
invMsg := btcwire.NewMsgInvSizeHint(uint(len(hashes)))
for i, hash := range hashes { for i, hash := range hashes {
// Another thread might have removed the transaction from the // Another thread might have removed the transaction from the
// pool since the initial query. // pool since the initial query.