LBRYCommunity/lbcd
1
0
Fork 0
Code Issues 17 Pull requests 4 Projects Releases 28 Packages Wiki Activity

Optimize transaction Deserialize.

Browse source 
The benchmark results for the current commit:

Before: BenchmarkDeserializeTx    500000              4018 ns/op
After:  BenchmarkDeserializeTx    500000              3780 ns/op

The cumulative benchmark results since commit b7b700fd5a:

Before: BenchmarkDeserializeTx    200000             10665 ns/op
After:  BenchmarkDeserializeTx    500000              3780 ns/op

This is part of the ongoing effort to optimize serialization as noted in
conformal/btcd#27.
This commit is contained in:
Dave Collins 2013-11-06 18:41:41 -06:00
parent 92b2f9e6b3
commit 9b7e3527b0
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
msgtx.go
View file

@ -229,10 +229,12 @@ func (tx *MsgTx) Copy() *MsgTx {
// See Deserialize for decoding transactions stored to disk, such as in a // See Deserialize for decoding transactions stored to disk, such as in a
// database, as opposed to decoding transactions from the wire. // database, as opposed to decoding transactions from the wire.
func (msg *MsgTx) BtcDecode(r io.Reader, pver uint32) error { func (msg *MsgTx) BtcDecode(r io.Reader, pver uint32) error {
err := readElement(r, &msg.Version) buf := make([]byte, 4)
_, err := io.ReadFull(r, buf)
if err != nil { if err != nil {
return err return err
} }
msg.Version = binary.LittleEndian.Uint32(buf)
count, err := readVarInt(r, pver) count, err := readVarInt(r, pver)
if err != nil { if err != nil {
@ -249,14 +251,14 @@ func (msg *MsgTx) BtcDecode(r io.Reader, pver uint32) error {
return messageError("MsgTx.BtcDecode", str) return messageError("MsgTx.BtcDecode", str)
} }
msg.TxIn = make([]*TxIn, 0, count) msg.TxIn = make([]*TxIn, count)
for i := uint64(0); i < count; i++ { for i := uint64(0); i < count; i++ {
ti := TxIn{} ti := TxIn{}
err = readTxIn(r, pver, msg.Version, &ti) err = readTxIn(r, pver, msg.Version, &ti)
if err != nil { if err != nil {
return err return err
} }
msg.TxIn = append(msg.TxIn, &ti) msg.TxIn[i] = &ti
} }
count, err = readVarInt(r, pver) count, err = readVarInt(r, pver)
@ -274,20 +276,21 @@ func (msg *MsgTx) BtcDecode(r io.Reader, pver uint32) error {
return messageError("MsgTx.BtcDecode", str) return messageError("MsgTx.BtcDecode", str)
} }
msg.TxOut = make([]*TxOut, 0, count) msg.TxOut = make([]*TxOut, count)
for i := uint64(0); i < count; i++ { for i := uint64(0); i < count; i++ {
to := TxOut{} to := TxOut{}
err = readTxOut(r, pver, msg.Version, &to) err = readTxOut(r, pver, msg.Version, &to)
if err != nil { if err != nil {
return err return err
} }
msg.TxOut = append(msg.TxOut, &to) msg.TxOut[i] = &to
} }
err = readElement(r, &msg.LockTime) _, err = io.ReadFull(r, buf)
if err != nil { if err != nil {
return err return err
} }
msg.LockTime = binary.LittleEndian.Uint32(buf)
return nil return nil
} }