LBRYCommunity/lbcd
1
0
Fork 0
Code Issues 17 Pull requests 4 Projects Releases 28 Packages Wiki Activity

Make var length string overflow tests consistent.

Browse source 
This commit modifies the variable length string overflow tests slight to
make them consistent with the other overflow tests.
This commit is contained in:
Dave Collins 2013-10-25 09:55:00 -05:00
parent a4c5c620c6
commit bd297491b9
1 changed files with 33 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
common_test.go
View file

@ -10,6 +10,7 @@ import (
"github.com/conformal/btcwire" "github.com/conformal/btcwire"
"github.com/davecgh/go-spew/spew" "github.com/davecgh/go-spew/spew"
"io" "io"
"reflect"
"strings" "strings"
"testing" "testing"
) )
@ -193,29 +194,6 @@ func TestVarStringWire(t *testing.T) {
continue continue
} }
} }
invtests := []struct {
buf []byte // Wire encoding
pver uint32 // Protocol version for wire encoding
}{
{append([]byte{0x02}, []byte("")...), pver},
//{append([]byte{0xfe, 0x00, 0x00, 0x00, 0x80}, []byte("")...), pver},
{append([]byte{0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01}, []byte("")...), pver},
//{append([]byte{0xff, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00}, []byte("")...), pver},
}
t.Logf("Running %d invalid tests", len(invtests))
for i, test := range invtests {
// Decode from wire format.
rbuf := bytes.NewBuffer(test.buf)
val, err := btcwire.TstReadVarString(rbuf, test.pver)
if err != nil {
t.Logf("readVarString #%d error %v (error expected)", i, err)
continue
}
t.Errorf("readVarString #%d\n got: %d want error != nil: %d", i,
val)
continue
}
} }
// TestVarStringWireErrors performs negative tests against wire encode and // TestVarStringWireErrors performs negative tests against wire encode and
@ -265,6 +243,38 @@ func TestVarStringWireErrors(t *testing.T) {
} }
} }
// TestVarStringOverflowErrors performs tests to ensure deserializing variable
// length strings intentionally crafted to use large values for the string
// length are handled properly. This could otherwise potentially be used as an
// attack vector.
func TestVarStringOverflowErrors(t *testing.T) {
pver := btcwire.ProtocolVersion
tests := []struct {
buf []byte // Wire encoding
pver uint32 // Protocol version for wire encoding
err error // Expected error
}{
{[]byte{0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff},
pver, &btcwire.MessageError{}},
{[]byte{0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01},
pver, &btcwire.MessageError{}},
}
t.Logf("Running %d tests", len(tests))
for i, test := range tests {
// Decode from wire format.
rbuf := bytes.NewBuffer(test.buf)
_, err := btcwire.TstReadVarString(rbuf, test.pver)
if reflect.TypeOf(err) != reflect.TypeOf(test.err) {
t.Errorf("readVarString #%d wrong error got: %v, "+
"want: %v", i, err, reflect.TypeOf(test.err))
continue
}
}
}
// TestRandomUint64 exercises the randomness of the random number generator on // TestRandomUint64 exercises the randomness of the random number generator on
// the system by ensuring the probability of the generated numbers. If the RNG // the system by ensuring the probability of the generated numbers. If the RNG
// is evenly distributed as a proper cryptographic RNG should be, there really // is evenly distributed as a proper cryptographic RNG should be, there really