LBRYCommunity/lbcd
1
0
Fork 0
Code Issues 17 Pull requests 4 Projects Releases 28 Packages Wiki Activity

Use NewReader instead of NewBuffer.

Browse source 
NewReader is slightly faster, but more importantly, ensures that the
data is read-only.
This commit is contained in:
David Hill 2014-06-05 13:58:28 -04:00
parent 8bce0ef3f8
commit bf48a97b0d
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
rpcserver.go
View file

@ -786,7 +786,7 @@ func handleDecodeRawTransaction(s *rpcServer, cmd btcjson.Cmd) (interface{}, err
} }
} }
var mtx btcwire.MsgTx var mtx btcwire.MsgTx
err = mtx.Deserialize(bytes.NewBuffer(serializedTx)) err = mtx.Deserialize(bytes.NewReader(serializedTx))
if err != nil { if err != nil {
return nil, btcjson.Error{ return nil, btcjson.Error{
Code: btcjson.ErrDeserialization.Code, Code: btcjson.ErrDeserialization.Code,
@ -1683,7 +1683,7 @@ func handleGetWorkSubmission(s *rpcServer, hexData string) (interface{}, error)
// Deserialize the block header from the data. // Deserialize the block header from the data.
var submittedHeader btcwire.BlockHeader var submittedHeader btcwire.BlockHeader
bhBuf := bytes.NewBuffer(data[0:btcwire.MaxBlockHeaderPayload]) bhBuf := bytes.NewReader(data[0:btcwire.MaxBlockHeaderPayload])
err = submittedHeader.Deserialize(bhBuf) err = submittedHeader.Deserialize(bhBuf)
if err != nil { if err != nil {
return false, btcjson.Error{ return false, btcjson.Error{
@ -1888,7 +1888,7 @@ func handleSendRawTransaction(s *rpcServer, cmd btcjson.Cmd) (interface{}, error
return nil, btcjson.ErrDecodeHexString return nil, btcjson.ErrDecodeHexString
} }
msgtx := btcwire.NewMsgTx() msgtx := btcwire.NewMsgTx()
err = msgtx.Deserialize(bytes.NewBuffer(serializedTx)) err = msgtx.Deserialize(bytes.NewReader(serializedTx))
if err != nil { if err != nil {
err := btcjson.Error{ err := btcjson.Error{
Code: btcjson.ErrDeserialization.Code, Code: btcjson.ErrDeserialization.Code,