LBRYCommunity/lbcd
1
0
Fork 0
Code Issues 17 Pull requests 4 Projects Releases 28 Packages Wiki Activity

server: Fix persistent peers not being removed properly

Browse source 
When a persistent peer is disconnected (for example due to a
network timeout), a connection retry is issued. The logic for
doing so failed to remove the peer from the peerState, causing
dead peer connections to fill the peerState. Since connections
in the peerState are counted towards the maxPeers limit, this
would cause btcd to eventually stop retrying connection.

This commit fixes the issue by properly removing the peer from
the peerState.
This commit is contained in:
Dario Nieuwenhuis 2015-12-27 20:56:40 +01:00
parent 89af747603
commit d0cdd53720
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
server.go
View file

@ -1124,12 +1124,10 @@ func (s *server) handleDonePeerMsg(state *peerState, sp *serverPeer) {
// persistent outbound connection. // persistent outbound connection.
if !sp.Inbound() && sp.persistent && atomic.LoadInt32(&s.shutdown) == 0 { if !sp.Inbound() && sp.persistent && atomic.LoadInt32(&s.shutdown) == 0 {
// Retry peer // Retry peer
sp = s.newOutboundPeer(sp.Addr(), sp.persistent) sp2 := s.newOutboundPeer(sp.Addr(), sp.persistent)
if sp != nil { if sp2 != nil {
go s.retryConn(sp, false) go s.retryConn(sp2, false)
} }
list[sp.ID()] = sp
return
} }
if !sp.Inbound() && sp.VersionKnown() { if !sp.Inbound() && sp.VersionKnown() {
state.outboundGroups[addrmgr.GroupKey(sp.NA())]-- state.outboundGroups[addrmgr.GroupKey(sp.NA())]--