Increase wire.MaxBlockPayload to 8MB #19

Merged

roylee17 merged 1 commit from roylee/increase-wire-maxblockpayload-to-8mb into master

2022-02-07 06:32:53 +01:00

roylee17 commented

2022-02-04 07:49:25 +01:00

(Migrated from github.com)

This variable seems redundant to the blockchain.MaxBlockBaseSize to make the wire and blockchain self-contained.
We've updated the blockchain.MaxBlockBaseSize to 8MB for LBRY, but missed this one?

This variable seems redundant to the blockchain.MaxBlockBaseSize to make the `wire` and `blockchain` self-contained. We've updated the `blockchain.MaxBlockBaseSize` to 8MB for LBRY, but missed this one?

BrannonKing (Migrated from github.com) reviewed 2022-02-04 07:49:25 +01:00

coveralls commented

2022-02-04 07:54:34 +01:00

(Migrated from github.com)

Pull Request Test Coverage Report for Build 1804753474

0 of 0 changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 51.822%

Files with Coverage Reduction	New Missed Lines	%
peer/peer.go	2	76.16%

Totals
Change from base Build 1782808406:	0.02%
Covered Lines:	22327
Relevant Lines:	43084

💛 - Coveralls

## Pull Request Test Coverage Report for [Build 1804753474](https://coveralls.io/builds/46275640) * **0** of **0** changed or added relevant lines in **0** files are covered. * **2** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.02%**) to **51.822%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-----|--------------|--: | | [peer/peer.go](https://coveralls.io/builds/46275640/source?filename=peer%2Fpeer.go#L1781) | 2 | 76.16% |  | Totals | [![Coverage Status](https://coveralls.io/builds/46275640/badge)](https://coveralls.io/builds/46275640) | | :-- | --: | | Change from base [Build 1782808406](https://coveralls.io/builds/46155281): | 0.02% | | Covered Lines: | 22327 | | Relevant Lines: | 43084 | --- ##### 💛 - [Coveralls](https://coveralls.io)

BrannonKing commented

2022-02-04 14:30:36 +01:00

(Migrated from github.com)

This PR has the fee functions as well; that doesn't seem quite right. As for the maximum block size, your change looks correct: https://github.com/lbryio/lbrycrd/blob/master/src/consensus/consensus.h

No reviewers

BrannonKing

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbcd#19

No description provided.