Embed sample-lbcd.conf contents at build time. Use embedded config... #33

Merged
moodyjon merged 1 commit from embed-conf-pr28 into master 2022-04-20 04:05:28 +02:00
moodyjon commented 2022-04-19 22:33:14 +02:00 (Migrated from github.com)
Fix for: https://github.com/lbryio/lbcd/issues/28
coveralls commented 2022-04-20 03:59:13 +02:00 (Migrated from github.com)

Pull Request Test Coverage Report for Build 2192036566

  • 4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 51.766%

Changes Missing Coverage Covered Lines Changed/Added Lines %
config.go 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
peer/peer.go 2 76.31%
btcec/signature.go 3 92.82%
Totals Coverage Status
Change from base Build 2091663636: 0.002%
Covered Lines: 22332
Relevant Lines: 43140

💛 - Coveralls
## Pull Request Test Coverage Report for [Build 2192036566](https://coveralls.io/builds/48401963) * **4** of **6** **(66.67%)** changed or added relevant lines in **1** file are covered. * **5** unchanged lines in **2** files lost coverage. * Overall coverage increased (+**0.002%**) to **51.766%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-----|--------------|--------|---: | | [config.go](https://coveralls.io/builds/48401963/source?filename=config.go#L1186) | 4 | 6 | 66.67% <!-- | **Total:** | **4** | **6** | **66.67%** | --> | Files with Coverage Reduction | New Missed Lines | % | | :-----|--------------|--: | | [peer/peer.go](https://coveralls.io/builds/48401963/source?filename=peer%2Fpeer.go#L1781) | 2 | 76.31% | | [btcec/signature.go](https://coveralls.io/builds/48401963/source?filename=btcec%2Fsignature.go#L405) | 3 | 92.82% | <!-- | **Total:** | **5** | | --> | Totals | [![Coverage Status](https://coveralls.io/builds/48401963/badge)](https://coveralls.io/builds/48401963) | | :-- | --: | | Change from base [Build 2091663636](https://coveralls.io/builds/47981667): | 0.002% | | Covered Lines: | 22332 | | Relevant Lines: | 43140 | --- ##### 💛 - [Coveralls](https://coveralls.io)
roylee17 commented 2022-04-20 04:05:33 +02:00 (Migrated from github.com)

LGTM. Thanks!

LGTM. Thanks!
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbcd#33
No description provided.