Enable txindex=1 as default #37

2022-05-13T00:46:29+02:00

kodxana commented

2022-05-13 00:46:29 +02:00

(Migrated from github.com)

Curently running lbcd inside docker do not enable txindex support with is required for most apps/services.
This PR adds txindex=1 to config file during build process to enable it by default.

Curently running lbcd inside docker do not enable txindex support with is required for most apps/services. This PR adds txindex=1 to config file during build process to enable it by default.

coveralls commented

2022-05-13 00:54:05 +02:00

(Migrated from github.com)

Pull Request Test Coverage Report for Build 2316428179

0 of 0 changed or added relevant lines in 0 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage increased (+13.0%) to 64.725%

Files with Coverage Reduction	New Missed Lines	%
mempool/mempool.go	1	66.23%
btcec/signature.go	3	92.82%

Totals
Change from base Build 2296271422:	13.0%
Covered Lines:	6510
Relevant Lines:	10058

💛 - Coveralls

## Pull Request Test Coverage Report for [Build 2316428179](https://coveralls.io/builds/49085097) * **0** of **0** changed or added relevant lines in **0** files are covered. * **4** unchanged lines in **2** files lost coverage. * Overall coverage increased (+**13.0%**) to **64.725%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-----|--------------|--: | | [mempool/mempool.go](https://coveralls.io/builds/49085097/source?filename=mempool%2Fmempool.go#L1326) | 1 | 66.23% | | [btcec/signature.go](https://coveralls.io/builds/49085097/source?filename=btcec%2Fsignature.go#L398) | 3 | 92.82% |  | Totals | [![Coverage Status](https://coveralls.io/builds/49085097/badge)](https://coveralls.io/builds/49085097) | | :-- | --: | | Change from base [Build 2296271422](https://coveralls.io/builds/48960861): | 13.0% | | Covered Lines: | 6510 | | Relevant Lines: | 10058 | --- ##### 💛 - [Coveralls](https://coveralls.io)

roylee17 commented

2022-05-13 17:44:00 +02:00

(Migrated from github.com)

The docker-publish.yml is a nice new add, which we should create a separate PR on its own. It would be great to parameterize (using inputs) the repo to push (default to lbry/lbcd), and the image tag. This allows us to publish official images as well as generate intermediate images during development and testing.

Regarding enabling txindex as default (which I just updated the title), we need to update multiple places (code, docs, instructions, configs) to keep things coherent. grep txindex in the source code

The `docker-publish.yml` is a nice new add, which we should create a separate PR on its own. It would be great to parameterize (using inputs) the repo to push (default to `lbry/lbcd`), and the image tag. This allows us to publish official images as well as generate intermediate images during development and testing. Regarding enabling `txindex` as default (which I just updated the title), we need to update multiple places (code, docs, instructions, configs) to keep things coherent. `grep txindex in the source code`

roylee17 (Migrated from github.com) reviewed 2022-05-13 17:51:02 +02:00

sample-lbcd.conf

					
				@ -379,4 +379,1 @@

				; Write memory profile to the specified file.

				; memprofile=

				; The port used to listen for HTTP profile requests.  The profile server will

roylee17 (Migrated from github.com) commented

2022-05-13 17:51:01 +02:00

We can revert this change now as line 300 already has a commented entry txindex=1, which should have been txindex=0.

The desired semantic in the sample-lbcd.conf is to have a commented entry showing default value for every setting.

Since now we're enabling it, leaving that commented out txindex=1

We can revert this change now as line 300 already has a commented entry `txindex=1`, which should have been `txindex=0`. The desired semantic in the sample-lbcd.conf is to have a commented entry showing default value for every setting. Since now we're enabling it, leaving that commented out `txindex=1`

kodxana commented

2022-05-13 17:54:39 +02:00

(Migrated from github.com)

Edited the config also added docker action for building testing and pushing containers though you might need make own edits.

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbcd#37