Allow environment var GOGC=<percent> to override hard-coded SetGCPercent(10) #45

Merged

moodyjon merged 1 commit from gogc_env_var into master

2022-06-03 18:19:55 +02:00

moodyjon commented

2022-06-03 15:48:24 +02:00

(Migrated from github.com)

Unbundled from PR https://github.com/lbryio/lbcd/pull/43

See that for usage/testing. (TODO)

The default (10) only lets heap grow 10% before triggering GC. Running with (for example) "GOGC=100" will reduce CPU usage while heap is allowed to fluctuate more.

Unbundled from PR https://github.com/lbryio/lbcd/pull/43 See that for usage/testing. (TODO) The default (10) only lets heap grow 10% before triggering GC. Running with (for example) "GOGC=100" will reduce CPU usage while heap is allowed to fluctuate more.

coveralls commented

2022-06-03 15:54:04 +02:00

(Migrated from github.com)

Pull Request Test Coverage Report for Build 2434997880

0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.01%) to 51.793%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lbcd.go	0	3	0.0%

Files with Coverage Reduction	New Missed Lines	%
peer/peer.go	2	76.31%
btcec/signature.go	3	92.82%

Totals
Change from base Build 2403229780:	0.01%
Covered Lines:	22413
Relevant Lines:	43274

💛 - Coveralls

## Pull Request Test Coverage Report for [Build 2434997880](https://coveralls.io/builds/49713006) * **0** of **3** **(0.0%)** changed or added relevant lines in **1** file are covered. * **5** unchanged lines in **2** files lost coverage. * Overall coverage increased (+**0.01%**) to **51.793%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-----|--------------|--------|---: | | [lbcd.go](https://coveralls.io/builds/49713006/source?filename=lbcd.go#L284) | 0 | 3 | 0.0%  | Files with Coverage Reduction | New Missed Lines | % | | :-----|--------------|--: | | [peer/peer.go](https://coveralls.io/builds/49713006/source?filename=peer%2Fpeer.go#L1781) | 2 | 76.31% | | [btcec/signature.go](https://coveralls.io/builds/49713006/source?filename=btcec%2Fsignature.go#L398) | 3 | 92.82% |  | Totals | [![Coverage Status](https://coveralls.io/builds/49713006/badge)](https://coveralls.io/builds/49713006) | | :-- | --: | | Change from base [Build 2403229780](https://coveralls.io/builds/49538653): | 0.01% | | Covered Lines: | 22413 | | Relevant Lines: | 43274 | --- ##### 💛 - [Coveralls](https://coveralls.io)

roylee17 commented

2022-06-03 18:20:00 +02:00

(Migrated from github.com)

LGTM. Thanks!

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbcd#45

No description provided.