Revert "mining: return witness_script instead of raw witness_c…" #82

Closed

roylee17 wants to merge 1 commit from roylee/fix-segwit-block-gbt-issue into master

roylee17 commented

2022-08-09 08:50:12 +02:00

(Migrated from github.com)

The original code is correct. It should be updated on the yimmp side.

This reverts commit d20a2e53b4.

The original code is correct. It should be updated on the yimmp side. This reverts commit d20a2e53b429138363af857653f9fd89deb71c6e.

coveralls commented

2022-08-09 08:54:48 +02:00

(Migrated from github.com)

Pull Request Test Coverage Report for Build 2823303111

0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.005%) to 51.867%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
mining/mining.go	0	1	0.0%

Files with Coverage Reduction	New Missed Lines	%
btcec/signature.go	3	92.82%

Totals
Change from base Build 2816275515:	0.005%
Covered Lines:	22471
Relevant Lines:	43324

💛 - Coveralls

## Pull Request Test Coverage Report for [Build 2823303111](https://coveralls.io/builds/51515595) * **0** of **1** **(0.0%)** changed or added relevant line in **1** file are covered. * **3** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.005%**) to **51.867%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-----|--------------|--------|---: | | [mining/mining.go](https://coveralls.io/builds/51515595/source?filename=mining%2Fmining.go#L910) | 0 | 1 | 0.0%  | Files with Coverage Reduction | New Missed Lines | % | | :-----|--------------|--: | | [btcec/signature.go](https://coveralls.io/builds/51515595/source?filename=btcec%2Fsignature.go#L398) | 3 | 92.82% |  | Totals | [![Coverage Status](https://coveralls.io/builds/51515595/badge)](https://coveralls.io/builds/51515595) | | :-- | --: | | Change from base [Build 2816275515](https://coveralls.io/builds/51482132): | 0.005% | | Covered Lines: | 22471 | | Relevant Lines: | 43324 | --- ##### 💛 - [Coveralls](https://coveralls.io)

roylee17 commented

2022-08-10 17:07:41 +02:00

(Migrated from github.com)

False alarm. This change is indeed needed.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbcd#82

No description provided.