txscript: validate claimscript size #88

Merged

roylee17 merged 1 commit from roylee/txscript-validate-claim-script-size into master

2022-08-31 00:30:08 +02:00

roylee17 commented

2022-08-30 22:34:15 +02:00

(Migrated from github.com)

No description provided.

coveralls commented

2022-08-30 22:39:17 +02:00

(Migrated from github.com)

Pull Request Test Coverage Report for Build 2959954759

5 of 19 (26.32%) changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 51.681%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
txscript/claimscript.go	5	19	26.32%

Files with Coverage Reduction	New Missed Lines	%
peer/peer.go	2	76.31%

Totals
Change from base Build 2858449374:	0.02%
Covered Lines:	22485
Relevant Lines:	43507

💛 - Coveralls

## Pull Request Test Coverage Report for [Build 2959954759](https://coveralls.io/builds/52079304) * **5** of **19** **(26.32%)** changed or added relevant lines in **1** file are covered. * **2** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.02%**) to **51.681%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-----|--------------|--------|---: | | [txscript/claimscript.go](https://coveralls.io/builds/52079304/source?filename=txscript%2Fclaimscript.go#L104) | 5 | 19 | 26.32%  | Files with Coverage Reduction | New Missed Lines | % | | :-----|--------------|--: | | [peer/peer.go](https://coveralls.io/builds/52079304/source?filename=peer%2Fpeer.go#L1781) | 2 | 76.31% |  | Totals | [![Coverage Status](https://coveralls.io/builds/52079304/badge)](https://coveralls.io/builds/52079304) | | :-- | --: | | Change from base [Build 2858449374](https://coveralls.io/builds/51652519): | 0.02% | | Covered Lines: | 22485 | | Relevant Lines: | 43507 | --- ##### 💛 - [Coveralls](https://coveralls.io)

moodyjon commented

2022-08-31 00:34:28 +02:00

(Migrated from github.com)

For what it's worth, I was looking at this for ~30min and comparing with lbrycrd. I did not see anything wrong, and no complaints.

👍 1

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbcd#88

No description provided.