policy: relax dust thrashold to 1000 dewies/kB, which aligns to lbrycrd #92

Merged

roylee17 merged 1 commit from relax-dust-thrashold-to-1000-dewies-per-kb into master

2022-09-02 00:28:08 +02:00

roylee17 commented

2022-09-01 23:14:46 +02:00

(Migrated from github.com)

An output is considered dust if the cost to the network to spend the
coins is more than 1/3 of the minimum free transaction relay fee, which
has a default rate of 1000 satoshis/kb

bitcoind refactored dust threshold calculation, which removed the
multiply factor of 3 from the code, but increased the DUST_RELAY_TX_FEE
from 1000 to 3000 (satoshi/kb).

lbrycrd adopted the refactored code but also kept the rate to
1000 dewies/kB, which means:

An output is considered dust if the cost to the network to spend the
coins is more than the minimum free transaction relay fee.

This commit updates lbcd to align the policy.

An output is considered dust if the cost to the network to spend the coins is more than 1/3 of the minimum free transaction relay fee, which has a default rate of 1000 satoshis/kb bitcoind refactored dust threshold calculation, which removed the multiply factor of 3 from the code, but increased the DUST_RELAY_TX_FEE from 1000 to 3000 (satoshi/kb). lbrycrd adopted the refactored code but also kept the rate to 1000 dewies/kB, which means: An output is considered dust if the cost to the network to spend the coins is more than the minimum free transaction relay fee. This commit updates lbcd to align the policy.

roylee17 commented

2022-09-01 23:17:15 +02:00

(Migrated from github.com)

Reference:

Reference: - https://github.com/bitcoin/bitcoin/commit/b1385852ef2ba45fd6926d75497646debf79e686 - https://github.com/lbryio/lbrycrd/commit/4da4ab1995945fc0b739927bcd0dbe9638285e41

roylee17 commented

2022-09-02 00:15:36 +02:00

(Migrated from github.com)

Fix #89

coveralls commented

2022-09-02 00:18:54 +02:00

(Migrated from github.com)

Pull Request Test Coverage Report for Build 2975325203

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
9 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.01%) to 51.653%

Files with Coverage Reduction	New Missed Lines	%
mempool/mempool.go	1	65.36%
peer/peer.go	8	76.31%

Totals
Change from base Build 2968257507:	0.01%
Covered Lines:	22486
Relevant Lines:	43533

💛 - Coveralls

## Pull Request Test Coverage Report for [Build 2975325203](https://coveralls.io/builds/52151581) * **1** of **1** **(100.0%)** changed or added relevant line in **1** file are covered. * **9** unchanged lines in **2** files lost coverage. * Overall coverage increased (+**0.01%**) to **51.653%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-----|--------------|--: | | [mempool/mempool.go](https://coveralls.io/builds/52151581/source?filename=mempool%2Fmempool.go#L1381) | 1 | 65.36% | | [peer/peer.go](https://coveralls.io/builds/52151581/source?filename=peer%2Fpeer.go#L1534) | 8 | 76.31% |  | Totals | [![Coverage Status](https://coveralls.io/builds/52151581/badge)](https://coveralls.io/builds/52151581) | | :-- | --: | | Change from base [Build 2968257507](https://coveralls.io/builds/52115551): | 0.01% | | Covered Lines: | 22486 | | Relevant Lines: | 43533 | --- ##### 💛 - [Coveralls](https://coveralls.io)

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbcd#92

No description provided.