Enable txindex=1 as default #37

Closed
kodxana wants to merge 211 commits from master into master
2 changed files with 40 additions and 3 deletions
Showing only changes of commit 4772e2e7fb - Show all commits

View file

@ -103,7 +103,7 @@ type config struct {
AddPeers []string `short:"a" long:"addpeer" description:"Add a peer to connect with at startup"`
AddrIndex bool `long:"addrindex" description:"Maintain a full address-based transaction index which makes the searchrawtransactions RPC available"`
AgentBlacklist []string `long:"agentblacklist" description:"A comma separated list of user-agent substrings which will cause lbcd to reject any peers whose user-agent contains any of the blacklisted substrings."`
AgentWhitelist []string `long:"agentwhitelist" description:"A comma separated list of user-agent substrings which will cause lbcd to require all peers' user-agents to contain one of the whitelisted substrings. The blacklist is applied before the blacklist, and an empty whitelist will allow all agents that do not fail the blacklist."`
AgentWhitelist []string `long:"agentwhitelist" description:"A comma separated list of user-agent substrings which will cause lbcd to require all peers' user-agents to contain one of the whitelisted substrings. The blacklist is applied before the whitelist, and an empty whitelist will allow all agents that do not fail the blacklist."`
BanDuration time.Duration `long:"banduration" description:"How long to ban misbehaving peers. Valid time units are {s, m, h}. Minimum 1 second"`
BanThreshold uint32 `long:"banthreshold" description:"Maximum allowed ban score before disconnecting and banning misbehaving peers."`
BlockMaxSize uint32 `long:"blockmaxsize" description:"Maximum block size in bytes to be used when creating a block"`

View file

@ -46,10 +46,10 @@
; to correlate connections.
; torisolation=1
; Use Universal Plug and Play (UPnP) to automatically open the listen port
; Do NOT use Universal Plug and Play (UPnP) to automatically open the listen port
; and obtain the external IP address from supported devices. NOTE: This option
; will have no effect if exernal IP addresses are specified.
; upnp=1
; noupnp=0
; Specify the external IP addresses your node is listening on. One address per
; line. lbcd will not contact 3rd-party sites to obtain external ip addresses.
@ -114,6 +114,9 @@
; banduration=24h
; banduration=11h30m15s
; Minimum time between attempts to send new inventory to a connected peer.
; trickleinterval=10s
; Add whitelisted IP networks and IPs. Connected peers whose IP matches a
; whitelist will not have their ban score increased.
; whitelist=127.0.0.1
@ -167,6 +170,16 @@
; Must not include characters '/', ':', '(' and ')'.
; uacomment=
; A comma separated list of user-agent substrings which will cause lbcd to reject
; any peers whose user-agent contains any of the blacklisted substrings.
; agentblacklist=
; A comma separated list of user-agent substrings which will cause lbcd to require
; all peers' user-agents to contain one of the whitelisted substrings. The blacklist
; is applied before the whitelist, and an empty whitelist will allow all agents that
; do not fail the blacklist.
; agentwhitelist=
; Disable committed peer filtering (CF).
; nocfilters=1
@ -223,6 +236,9 @@
; Specify the maximum number of concurrent RPC websocket clients.
; rpcmaxwebsockets=25
; Max number of concurrent RPC requests that may be processed concurrently.
; rpcmaxconcurrentreqs=20
; Mirror some JSON-RPC quirks of Bitcoin Core -- NOTE: Discouraged unless
; interoperability issues need to be worked around
; rpcquirks=1
@ -237,6 +253,12 @@
; the default).
; notls=1
; File containing the certificate file.
; rpccert=~/.lbcd/rpc.cert
; File containing the certificate key.
; rpckey=~/.lbcd/rpc.key
; ------------------------------------------------------------------------------
; Mempool Settings - The following options
@ -264,6 +286,10 @@
; Reject non-standard transactions regardless of default network settings.
; rejectnonstd=1
; Reject transactions that attempt to replace existing transactions within
; the mempool through the Replace-By-Fee (RBF) signaling policy.
; rejectreplacement=0
; ------------------------------------------------------------------------------
; Optional Indexes
@ -319,6 +345,12 @@
; to the consensus limit if it is larger than that value.
; blockmaxsize=750000
; Mininum block weight to be used when creating a block.
; blockminweight=0
; Maximum block weight to be used when creating a block.
; blockmaxweight=3000000
; Specify the size in bytes of the high-priority/low-fee area when creating a
; block. Transactions which consist of large amounts, old inputs, and small
; sizes have the highest priority. One consequence of this is that as low-fee
@ -331,6 +363,8 @@
; ------------------------------------------------------------------------------
; Debug
; ------------------------------------------------------------------------------
; Directory to log output.
; logdir=~/.lbcd/logs
; Debug logging level.
; Valid levels are {trace, debug, info, warn, error, critical}
@ -339,6 +373,9 @@
; available subsystems.
; debuglevel=info
; Write CPU profile to the specified file.
; cpuprofile=
; The port used to listen for HTTP profile requests. The profile server will
roylee17 commented 2022-05-13 17:51:01 +02:00 (Migrated from github.com)
Review

We can revert this change now as line 300 already has a commented entry txindex=1, which should have been txindex=0.

The desired semantic in the sample-lbcd.conf is to have a commented entry showing default value for every setting.

Since now we're enabling it, leaving that commented out txindex=1

We can revert this change now as line 300 already has a commented entry `txindex=1`, which should have been `txindex=0`. The desired semantic in the sample-lbcd.conf is to have a commented entry showing default value for every setting. Since now we're enabling it, leaving that commented out `txindex=1`
; be disabled if this option is not specified. The profile information can be
; accessed at http://localhost:<profileport>/debug/pprof once running.