144822d4bf
This commit removes the TxnCount field from the BlockHeader type and updates the tests accordingly. Note that this change does not affect the actual wire protocol encoding in any way. The reason the field has been removed is it really doesn't belong there even though the wire protocol wiki entry on the official bitcoin wiki implies it does. The implication is an artifact from the way the reference implementation serializes headers (MsgHeaders) messages. It includes the transaction count, which is naturally always 0 for headers, along with every header. However, in reality, a block header does not include the transaction count. This can be evidenced by looking at how a block hash is calculated. It is only up to and including the Nonce field (a total of 80 bytes). From an API standpoint, having the field as part of the BlockHeader type results in several odd cases. For example, the transaction count for MsgBlocks (the only place that actually has a real transaction count since MsgHeaders does not) is available by taking the len of the Transactions slice. As such, having the extra field in the BlockHeader is really a useless field that could potentially get out of sync and cause the encode to fail. Another example is related to deserializing a block header from the database in order to serve it in response to a getheaders (MsgGetheaders) request. If a block header is assumed to have the transaction count as a part of it, then derserializing a block header not only consumes more than the 80 bytes that actually comprise the header as stated above, but you then need to change the transaction count to 0 before sending the headers (MsgHeaders) message. So, not only are you reading and deserializing more bytes than needed, but worse, you generally have to make a copy of it so you can change the transaction count without busting cached headers. This is part 1 of #13.
350 lines
10 KiB
Go
350 lines
10 KiB
Go
// Copyright (c) 2013-2014 Conformal Systems LLC.
|
|
// Use of this source code is governed by an ISC
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package btcwire_test
|
|
|
|
import (
|
|
"bytes"
|
|
"github.com/conformal/btcwire"
|
|
"github.com/davecgh/go-spew/spew"
|
|
"io"
|
|
"reflect"
|
|
"testing"
|
|
)
|
|
|
|
// TestHeaders tests the MsgHeaders API.
|
|
func TestHeaders(t *testing.T) {
|
|
pver := uint32(60002)
|
|
|
|
// Ensure the command is expected value.
|
|
wantCmd := "headers"
|
|
msg := btcwire.NewMsgHeaders()
|
|
if cmd := msg.Command(); cmd != wantCmd {
|
|
t.Errorf("NewMsgHeaders: wrong command - got %v want %v",
|
|
cmd, wantCmd)
|
|
}
|
|
|
|
// Ensure max payload is expected value for latest protocol version.
|
|
// Num headers (varInt) + max allowed headers (header length + 1 byte
|
|
// for the number of transactions which is always 0).
|
|
wantPayload := uint32(162009)
|
|
maxPayload := msg.MaxPayloadLength(pver)
|
|
if maxPayload != wantPayload {
|
|
t.Errorf("MaxPayloadLength: wrong max payload length for "+
|
|
"protocol version %d - got %v, want %v", pver,
|
|
maxPayload, wantPayload)
|
|
}
|
|
|
|
// Ensure headers are added properly.
|
|
bh := &blockOne.Header
|
|
msg.AddBlockHeader(bh)
|
|
if !reflect.DeepEqual(msg.Headers[0], bh) {
|
|
t.Errorf("AddHeader: wrong header - got %v, want %v",
|
|
spew.Sdump(msg.Headers),
|
|
spew.Sdump(bh))
|
|
}
|
|
|
|
// Ensure adding more than the max allowed headers per message returns
|
|
// error.
|
|
var err error
|
|
for i := 0; i < btcwire.MaxBlockHeadersPerMsg+1; i++ {
|
|
err = msg.AddBlockHeader(bh)
|
|
}
|
|
if reflect.TypeOf(err) != reflect.TypeOf(&btcwire.MessageError{}) {
|
|
t.Errorf("AddBlockHeader: expected error on too many headers " +
|
|
"not received")
|
|
}
|
|
|
|
return
|
|
}
|
|
|
|
// TestHeadersWire tests the MsgHeaders wire encode and decode for various
|
|
// numbers of headers and protocol versions.
|
|
func TestHeadersWire(t *testing.T) {
|
|
hash := btcwire.GenesisHash
|
|
merkleHash := blockOne.Header.MerkleRoot
|
|
bits := uint32(0x1d00ffff)
|
|
nonce := uint32(0x9962e301)
|
|
bh := btcwire.NewBlockHeader(&hash, &merkleHash, bits, nonce)
|
|
bh.Version = blockOne.Header.Version
|
|
bh.Timestamp = blockOne.Header.Timestamp
|
|
|
|
// Empty headers message.
|
|
noHeaders := btcwire.NewMsgHeaders()
|
|
noHeadersEncoded := []byte{
|
|
0x00, // Varint for number of headers
|
|
}
|
|
|
|
// Headers message with one header.
|
|
oneHeader := btcwire.NewMsgHeaders()
|
|
oneHeader.AddBlockHeader(bh)
|
|
oneHeaderEncoded := []byte{
|
|
0x01, // VarInt for number of headers.
|
|
0x01, 0x00, 0x00, 0x00, // Version 1
|
|
0x6f, 0xe2, 0x8c, 0x0a, 0xb6, 0xf1, 0xb3, 0x72,
|
|
0xc1, 0xa6, 0xa2, 0x46, 0xae, 0x63, 0xf7, 0x4f,
|
|
0x93, 0x1e, 0x83, 0x65, 0xe1, 0x5a, 0x08, 0x9c,
|
|
0x68, 0xd6, 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, // PrevBlock
|
|
0x98, 0x20, 0x51, 0xfd, 0x1e, 0x4b, 0xa7, 0x44,
|
|
0xbb, 0xbe, 0x68, 0x0e, 0x1f, 0xee, 0x14, 0x67,
|
|
0x7b, 0xa1, 0xa3, 0xc3, 0x54, 0x0b, 0xf7, 0xb1,
|
|
0xcd, 0xb6, 0x06, 0xe8, 0x57, 0x23, 0x3e, 0x0e, // MerkleRoot
|
|
0x61, 0xbc, 0x66, 0x49, // Timestamp
|
|
0xff, 0xff, 0x00, 0x1d, // Bits
|
|
0x01, 0xe3, 0x62, 0x99, // Nonce
|
|
0x00, // TxnCount (0 for headers message)
|
|
}
|
|
|
|
tests := []struct {
|
|
in *btcwire.MsgHeaders // Message to encode
|
|
out *btcwire.MsgHeaders // Expected decoded message
|
|
buf []byte // Wire encoding
|
|
pver uint32 // Protocol version for wire encoding
|
|
}{
|
|
// Latest protocol version with no headers.
|
|
{
|
|
noHeaders,
|
|
noHeaders,
|
|
noHeadersEncoded,
|
|
btcwire.ProtocolVersion,
|
|
},
|
|
|
|
// Latest protocol version with one header.
|
|
{
|
|
oneHeader,
|
|
oneHeader,
|
|
oneHeaderEncoded,
|
|
btcwire.ProtocolVersion,
|
|
},
|
|
|
|
// Protocol version BIP0035Version with no headers.
|
|
{
|
|
noHeaders,
|
|
noHeaders,
|
|
noHeadersEncoded,
|
|
btcwire.BIP0035Version,
|
|
},
|
|
|
|
// Protocol version BIP0035Version with one header.
|
|
{
|
|
oneHeader,
|
|
oneHeader,
|
|
oneHeaderEncoded,
|
|
btcwire.BIP0035Version,
|
|
},
|
|
|
|
// Protocol version BIP0031Version with no headers.
|
|
{
|
|
noHeaders,
|
|
noHeaders,
|
|
noHeadersEncoded,
|
|
btcwire.BIP0031Version,
|
|
},
|
|
|
|
// Protocol version BIP0031Version with one header.
|
|
{
|
|
oneHeader,
|
|
oneHeader,
|
|
oneHeaderEncoded,
|
|
btcwire.BIP0031Version,
|
|
},
|
|
// Protocol version NetAddressTimeVersion with no headers.
|
|
{
|
|
noHeaders,
|
|
noHeaders,
|
|
noHeadersEncoded,
|
|
btcwire.NetAddressTimeVersion,
|
|
},
|
|
|
|
// Protocol version NetAddressTimeVersion with one header.
|
|
{
|
|
oneHeader,
|
|
oneHeader,
|
|
oneHeaderEncoded,
|
|
btcwire.NetAddressTimeVersion,
|
|
},
|
|
|
|
// Protocol version MultipleAddressVersion with no headers.
|
|
{
|
|
noHeaders,
|
|
noHeaders,
|
|
noHeadersEncoded,
|
|
btcwire.MultipleAddressVersion,
|
|
},
|
|
|
|
// Protocol version MultipleAddressVersion with one header.
|
|
{
|
|
oneHeader,
|
|
oneHeader,
|
|
oneHeaderEncoded,
|
|
btcwire.MultipleAddressVersion,
|
|
},
|
|
}
|
|
|
|
t.Logf("Running %d tests", len(tests))
|
|
for i, test := range tests {
|
|
// Encode the message to wire format.
|
|
var buf bytes.Buffer
|
|
err := test.in.BtcEncode(&buf, test.pver)
|
|
if err != nil {
|
|
t.Errorf("BtcEncode #%d error %v", i, err)
|
|
continue
|
|
}
|
|
if !bytes.Equal(buf.Bytes(), test.buf) {
|
|
t.Errorf("BtcEncode #%d\n got: %s want: %s", i,
|
|
spew.Sdump(buf.Bytes()), spew.Sdump(test.buf))
|
|
continue
|
|
}
|
|
|
|
// Decode the message from wire format.
|
|
var msg btcwire.MsgHeaders
|
|
rbuf := bytes.NewBuffer(test.buf)
|
|
err = msg.BtcDecode(rbuf, test.pver)
|
|
if err != nil {
|
|
t.Errorf("BtcDecode #%d error %v", i, err)
|
|
continue
|
|
}
|
|
if !reflect.DeepEqual(&msg, test.out) {
|
|
t.Errorf("BtcDecode #%d\n got: %s want: %s", i,
|
|
spew.Sdump(&msg), spew.Sdump(test.out))
|
|
continue
|
|
}
|
|
}
|
|
}
|
|
|
|
// TestHeadersWireErrors performs negative tests against wire encode and decode
|
|
// of MsgHeaders to confirm error paths work correctly.
|
|
func TestHeadersWireErrors(t *testing.T) {
|
|
pver := btcwire.ProtocolVersion
|
|
btcwireErr := &btcwire.MessageError{}
|
|
|
|
hash := btcwire.GenesisHash
|
|
merkleHash := blockOne.Header.MerkleRoot
|
|
bits := uint32(0x1d00ffff)
|
|
nonce := uint32(0x9962e301)
|
|
bh := btcwire.NewBlockHeader(&hash, &merkleHash, bits, nonce)
|
|
bh.Version = blockOne.Header.Version
|
|
bh.Timestamp = blockOne.Header.Timestamp
|
|
|
|
// Headers message with one header.
|
|
oneHeader := btcwire.NewMsgHeaders()
|
|
oneHeader.AddBlockHeader(bh)
|
|
oneHeaderEncoded := []byte{
|
|
0x01, // VarInt for number of headers.
|
|
0x01, 0x00, 0x00, 0x00, // Version 1
|
|
0x6f, 0xe2, 0x8c, 0x0a, 0xb6, 0xf1, 0xb3, 0x72,
|
|
0xc1, 0xa6, 0xa2, 0x46, 0xae, 0x63, 0xf7, 0x4f,
|
|
0x93, 0x1e, 0x83, 0x65, 0xe1, 0x5a, 0x08, 0x9c,
|
|
0x68, 0xd6, 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, // PrevBlock
|
|
0x98, 0x20, 0x51, 0xfd, 0x1e, 0x4b, 0xa7, 0x44,
|
|
0xbb, 0xbe, 0x68, 0x0e, 0x1f, 0xee, 0x14, 0x67,
|
|
0x7b, 0xa1, 0xa3, 0xc3, 0x54, 0x0b, 0xf7, 0xb1,
|
|
0xcd, 0xb6, 0x06, 0xe8, 0x57, 0x23, 0x3e, 0x0e, // MerkleRoot
|
|
0x61, 0xbc, 0x66, 0x49, // Timestamp
|
|
0xff, 0xff, 0x00, 0x1d, // Bits
|
|
0x01, 0xe3, 0x62, 0x99, // Nonce
|
|
0x00, // TxnCount (0 for headers message)
|
|
}
|
|
|
|
// Message that forces an error by having more than the max allowed
|
|
// headers.
|
|
maxHeaders := btcwire.NewMsgHeaders()
|
|
for i := 0; i < btcwire.MaxBlockHeadersPerMsg; i++ {
|
|
maxHeaders.AddBlockHeader(bh)
|
|
}
|
|
maxHeaders.Headers = append(maxHeaders.Headers, bh)
|
|
maxHeadersEncoded := []byte{
|
|
0xfd, 0xd1, 0x07, // Varint for number of addresses (2001)7D1
|
|
}
|
|
|
|
// Intentionally invalid block header that has a transaction count used
|
|
// to force errors.
|
|
bhTrans := btcwire.NewBlockHeader(&hash, &merkleHash, bits, nonce)
|
|
bhTrans.Version = blockOne.Header.Version
|
|
bhTrans.Timestamp = blockOne.Header.Timestamp
|
|
|
|
transHeader := btcwire.NewMsgHeaders()
|
|
transHeader.AddBlockHeader(bhTrans)
|
|
transHeaderEncoded := []byte{
|
|
0x01, // VarInt for number of headers.
|
|
0x01, 0x00, 0x00, 0x00, // Version 1
|
|
0x6f, 0xe2, 0x8c, 0x0a, 0xb6, 0xf1, 0xb3, 0x72,
|
|
0xc1, 0xa6, 0xa2, 0x46, 0xae, 0x63, 0xf7, 0x4f,
|
|
0x93, 0x1e, 0x83, 0x65, 0xe1, 0x5a, 0x08, 0x9c,
|
|
0x68, 0xd6, 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, // PrevBlock
|
|
0x98, 0x20, 0x51, 0xfd, 0x1e, 0x4b, 0xa7, 0x44,
|
|
0xbb, 0xbe, 0x68, 0x0e, 0x1f, 0xee, 0x14, 0x67,
|
|
0x7b, 0xa1, 0xa3, 0xc3, 0x54, 0x0b, 0xf7, 0xb1,
|
|
0xcd, 0xb6, 0x06, 0xe8, 0x57, 0x23, 0x3e, 0x0e, // MerkleRoot
|
|
0x61, 0xbc, 0x66, 0x49, // Timestamp
|
|
0xff, 0xff, 0x00, 0x1d, // Bits
|
|
0x01, 0xe3, 0x62, 0x99, // Nonce
|
|
0x01, // TxnCount (should be 0 for headers message, but 1 to force error)
|
|
}
|
|
|
|
tests := []struct {
|
|
in *btcwire.MsgHeaders // Value to encode
|
|
buf []byte // Wire encoding
|
|
pver uint32 // Protocol version for wire encoding
|
|
max int // Max size of fixed buffer to induce errors
|
|
writeErr error // Expected write error
|
|
readErr error // Expected read error
|
|
}{
|
|
// Latest protocol version with intentional read/write errors.
|
|
// Force error in header count.
|
|
{oneHeader, oneHeaderEncoded, pver, 0, io.ErrShortWrite, io.EOF},
|
|
// Force error in block header.
|
|
{oneHeader, oneHeaderEncoded, pver, 5, io.ErrShortWrite, io.EOF},
|
|
// Force error with greater than max headers.
|
|
{maxHeaders, maxHeadersEncoded, pver, 3, btcwireErr, btcwireErr},
|
|
// Force error with number of transactions.
|
|
{transHeader, transHeaderEncoded, pver, 81, io.ErrShortWrite, io.EOF},
|
|
// Force error with included transactions.
|
|
{transHeader, transHeaderEncoded, pver, len(transHeaderEncoded), nil, btcwireErr},
|
|
}
|
|
|
|
t.Logf("Running %d tests", len(tests))
|
|
for i, test := range tests {
|
|
// Encode to wire format.
|
|
w := newFixedWriter(test.max)
|
|
err := test.in.BtcEncode(w, test.pver)
|
|
if reflect.TypeOf(err) != reflect.TypeOf(test.writeErr) {
|
|
t.Errorf("BtcEncode #%d wrong error got: %v, want: %v",
|
|
i, err, test.writeErr)
|
|
continue
|
|
}
|
|
|
|
// For errors which are not of type btcwire.MessageError, check
|
|
// them for equality.
|
|
if _, ok := err.(*btcwire.MessageError); !ok {
|
|
if err != test.writeErr {
|
|
t.Errorf("BtcEncode #%d wrong error got: %v, "+
|
|
"want: %v", i, err, test.writeErr)
|
|
continue
|
|
}
|
|
}
|
|
|
|
// Decode from wire format.
|
|
var msg btcwire.MsgHeaders
|
|
r := newFixedReader(test.max, test.buf)
|
|
err = msg.BtcDecode(r, test.pver)
|
|
if reflect.TypeOf(err) != reflect.TypeOf(test.readErr) {
|
|
t.Errorf("BtcDecode #%d wrong error got: %v, want: %v",
|
|
i, err, test.readErr)
|
|
continue
|
|
}
|
|
|
|
// For errors which are not of type btcwire.MessageError, check
|
|
// them for equality.
|
|
if _, ok := err.(*btcwire.MessageError); !ok {
|
|
if err != test.readErr {
|
|
t.Errorf("BtcDecode #%d wrong error got: %v, "+
|
|
"want: %v", i, err, test.readErr)
|
|
continue
|
|
}
|
|
}
|
|
|
|
}
|
|
}
|