2015-12-01 19:44:58 +01:00
|
|
|
// Copyright (c) 2013-2015 The btcsuite developers
|
|
|
|
// Use of this source code is governed by an ISC
|
|
|
|
// license that can be found in the LICENSE file.
|
Modernize the RPC server.
This is a rather monolithic commit that moves the old RPC server to
its own package (rpc/legacyrpc), introduces a new RPC server using
gRPC (rpc/rpcserver), and provides the ability to defer wallet loading
until request at a later time by an RPC (--noinitialload).
The legacy RPC server remains the default for now while the new gRPC
server is not enabled by default. Enabling the new server requires
setting a listen address (--experimenalrpclisten). This experimental
flag is used to effectively feature gate the server until it is ready
to use as a default. Both RPC servers can be run at the same time,
but require binding to different listen addresses.
In theory, with the legacy RPC server now living in its own package it
should become much easier to unit test the handlers. This will be
useful for any future changes to the package, as compatibility with
Core's wallet is still desired.
Type safety has also been improved in the legacy RPC server. Multiple
handler types are now used for methods that do and do not require the
RPC client as a dependency. This can statically help prevent nil
pointer dereferences, and was very useful for catching bugs during
refactoring.
To synchronize the wallet loading process between the main package
(the default) and through the gRPC WalletLoader service (with the
--noinitialload option), as well as increasing the loose coupling of
packages, a new wallet.Loader type has been added. All creating and
loading of existing wallets is done through a single Loader instance,
and callbacks can be attached to the instance to run after the wallet
has been opened. This is how the legacy RPC server is associated with
a loaded wallet, even after the wallet is loaded by a gRPC method in a
completely unrelated package.
Documentation for the new RPC server has been added to the
rpc/documentation directory. The documentation includes a
specification for the new RPC API, addresses how to make changes to
the server implementation, and provides short example clients in
several different languages.
Some of the new RPC methods are not implementated exactly as described
by the specification. These are considered bugs with the
implementation, not the spec. Known bugs are commented as such.
2015-06-01 21:57:50 +02:00
|
|
|
|
|
|
|
package legacyrpc
|
|
|
|
|
|
|
|
import (
|
|
|
|
"errors"
|
|
|
|
|
|
|
|
"github.com/btcsuite/btcd/btcjson"
|
|
|
|
)
|
|
|
|
|
|
|
|
// TODO(jrick): There are several error paths which 'replace' various errors
|
|
|
|
// with a more appropiate error from the btcjson package. Create a map of
|
|
|
|
// these replacements so they can be handled once after an RPC handler has
|
|
|
|
// returned and before the error is marshaled.
|
|
|
|
|
|
|
|
// Error types to simplify the reporting of specific categories of
|
|
|
|
// errors, and their *btcjson.RPCError creation.
|
|
|
|
type (
|
|
|
|
// DeserializationError describes a failed deserializaion due to bad
|
2016-03-09 20:34:02 +01:00
|
|
|
// user input. It corresponds to btcjson.ErrRPCDeserialization.
|
Modernize the RPC server.
This is a rather monolithic commit that moves the old RPC server to
its own package (rpc/legacyrpc), introduces a new RPC server using
gRPC (rpc/rpcserver), and provides the ability to defer wallet loading
until request at a later time by an RPC (--noinitialload).
The legacy RPC server remains the default for now while the new gRPC
server is not enabled by default. Enabling the new server requires
setting a listen address (--experimenalrpclisten). This experimental
flag is used to effectively feature gate the server until it is ready
to use as a default. Both RPC servers can be run at the same time,
but require binding to different listen addresses.
In theory, with the legacy RPC server now living in its own package it
should become much easier to unit test the handlers. This will be
useful for any future changes to the package, as compatibility with
Core's wallet is still desired.
Type safety has also been improved in the legacy RPC server. Multiple
handler types are now used for methods that do and do not require the
RPC client as a dependency. This can statically help prevent nil
pointer dereferences, and was very useful for catching bugs during
refactoring.
To synchronize the wallet loading process between the main package
(the default) and through the gRPC WalletLoader service (with the
--noinitialload option), as well as increasing the loose coupling of
packages, a new wallet.Loader type has been added. All creating and
loading of existing wallets is done through a single Loader instance,
and callbacks can be attached to the instance to run after the wallet
has been opened. This is how the legacy RPC server is associated with
a loaded wallet, even after the wallet is loaded by a gRPC method in a
completely unrelated package.
Documentation for the new RPC server has been added to the
rpc/documentation directory. The documentation includes a
specification for the new RPC API, addresses how to make changes to
the server implementation, and provides short example clients in
several different languages.
Some of the new RPC methods are not implementated exactly as described
by the specification. These are considered bugs with the
implementation, not the spec. Known bugs are commented as such.
2015-06-01 21:57:50 +02:00
|
|
|
DeserializationError struct {
|
|
|
|
error
|
|
|
|
}
|
|
|
|
|
|
|
|
// InvalidParameterError describes an invalid parameter passed by
|
2016-03-09 20:34:02 +01:00
|
|
|
// the user. It corresponds to btcjson.ErrRPCInvalidParameter.
|
Modernize the RPC server.
This is a rather monolithic commit that moves the old RPC server to
its own package (rpc/legacyrpc), introduces a new RPC server using
gRPC (rpc/rpcserver), and provides the ability to defer wallet loading
until request at a later time by an RPC (--noinitialload).
The legacy RPC server remains the default for now while the new gRPC
server is not enabled by default. Enabling the new server requires
setting a listen address (--experimenalrpclisten). This experimental
flag is used to effectively feature gate the server until it is ready
to use as a default. Both RPC servers can be run at the same time,
but require binding to different listen addresses.
In theory, with the legacy RPC server now living in its own package it
should become much easier to unit test the handlers. This will be
useful for any future changes to the package, as compatibility with
Core's wallet is still desired.
Type safety has also been improved in the legacy RPC server. Multiple
handler types are now used for methods that do and do not require the
RPC client as a dependency. This can statically help prevent nil
pointer dereferences, and was very useful for catching bugs during
refactoring.
To synchronize the wallet loading process between the main package
(the default) and through the gRPC WalletLoader service (with the
--noinitialload option), as well as increasing the loose coupling of
packages, a new wallet.Loader type has been added. All creating and
loading of existing wallets is done through a single Loader instance,
and callbacks can be attached to the instance to run after the wallet
has been opened. This is how the legacy RPC server is associated with
a loaded wallet, even after the wallet is loaded by a gRPC method in a
completely unrelated package.
Documentation for the new RPC server has been added to the
rpc/documentation directory. The documentation includes a
specification for the new RPC API, addresses how to make changes to
the server implementation, and provides short example clients in
several different languages.
Some of the new RPC methods are not implementated exactly as described
by the specification. These are considered bugs with the
implementation, not the spec. Known bugs are commented as such.
2015-06-01 21:57:50 +02:00
|
|
|
InvalidParameterError struct {
|
|
|
|
error
|
|
|
|
}
|
|
|
|
|
|
|
|
// ParseError describes a failed parse due to bad user input. It
|
2016-03-09 20:34:02 +01:00
|
|
|
// corresponds to btcjson.ErrRPCParse.
|
Modernize the RPC server.
This is a rather monolithic commit that moves the old RPC server to
its own package (rpc/legacyrpc), introduces a new RPC server using
gRPC (rpc/rpcserver), and provides the ability to defer wallet loading
until request at a later time by an RPC (--noinitialload).
The legacy RPC server remains the default for now while the new gRPC
server is not enabled by default. Enabling the new server requires
setting a listen address (--experimenalrpclisten). This experimental
flag is used to effectively feature gate the server until it is ready
to use as a default. Both RPC servers can be run at the same time,
but require binding to different listen addresses.
In theory, with the legacy RPC server now living in its own package it
should become much easier to unit test the handlers. This will be
useful for any future changes to the package, as compatibility with
Core's wallet is still desired.
Type safety has also been improved in the legacy RPC server. Multiple
handler types are now used for methods that do and do not require the
RPC client as a dependency. This can statically help prevent nil
pointer dereferences, and was very useful for catching bugs during
refactoring.
To synchronize the wallet loading process between the main package
(the default) and through the gRPC WalletLoader service (with the
--noinitialload option), as well as increasing the loose coupling of
packages, a new wallet.Loader type has been added. All creating and
loading of existing wallets is done through a single Loader instance,
and callbacks can be attached to the instance to run after the wallet
has been opened. This is how the legacy RPC server is associated with
a loaded wallet, even after the wallet is loaded by a gRPC method in a
completely unrelated package.
Documentation for the new RPC server has been added to the
rpc/documentation directory. The documentation includes a
specification for the new RPC API, addresses how to make changes to
the server implementation, and provides short example clients in
several different languages.
Some of the new RPC methods are not implementated exactly as described
by the specification. These are considered bugs with the
implementation, not the spec. Known bugs are commented as such.
2015-06-01 21:57:50 +02:00
|
|
|
ParseError struct {
|
|
|
|
error
|
|
|
|
}
|
|
|
|
)
|
|
|
|
|
|
|
|
// Errors variables that are defined once here to avoid duplication below.
|
|
|
|
var (
|
|
|
|
ErrNeedPositiveAmount = InvalidParameterError{
|
|
|
|
errors.New("amount must be positive"),
|
|
|
|
}
|
|
|
|
|
|
|
|
ErrNeedPositiveMinconf = InvalidParameterError{
|
|
|
|
errors.New("minconf must be positive"),
|
|
|
|
}
|
|
|
|
|
|
|
|
ErrAddressNotInWallet = btcjson.RPCError{
|
|
|
|
Code: btcjson.ErrRPCWallet,
|
|
|
|
Message: "address not found in wallet",
|
|
|
|
}
|
|
|
|
|
|
|
|
ErrAccountNameNotFound = btcjson.RPCError{
|
|
|
|
Code: btcjson.ErrRPCWalletInvalidAccountName,
|
|
|
|
Message: "account name not found",
|
|
|
|
}
|
|
|
|
|
|
|
|
ErrUnloadedWallet = btcjson.RPCError{
|
|
|
|
Code: btcjson.ErrRPCWallet,
|
|
|
|
Message: "Request requires a wallet but wallet has not loaded yet",
|
|
|
|
}
|
|
|
|
|
|
|
|
ErrWalletUnlockNeeded = btcjson.RPCError{
|
|
|
|
Code: btcjson.ErrRPCWalletUnlockNeeded,
|
|
|
|
Message: "Enter the wallet passphrase with walletpassphrase first",
|
|
|
|
}
|
|
|
|
|
|
|
|
ErrNotImportedAccount = btcjson.RPCError{
|
|
|
|
Code: btcjson.ErrRPCWallet,
|
|
|
|
Message: "imported addresses must belong to the imported account",
|
|
|
|
}
|
|
|
|
|
|
|
|
ErrNoTransactionInfo = btcjson.RPCError{
|
|
|
|
Code: btcjson.ErrRPCNoTxInfo,
|
|
|
|
Message: "No information for transaction",
|
|
|
|
}
|
|
|
|
|
|
|
|
ErrReservedAccountName = btcjson.RPCError{
|
|
|
|
Code: btcjson.ErrRPCInvalidParameter,
|
|
|
|
Message: "Account name is reserved by RPC server",
|
|
|
|
}
|
|
|
|
)
|