Update RPCs to support multi-scope multi-account [WIP] #26
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
mining
question
rpc
ux
wallet
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbcwallet#26
Loading…
Reference in a new issue
No description provided.
Delete branch "roylee/support-multi-scope-multi-account"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
bitcoin-core used to have an accounting system, which has been ripped off and replaced by labels around 0.17.0. Over the last few releases, bitcoin-core has completely deprecated account-related RPCs and account-related fields of other RPCs.
lbcwallet(and btcwallet) and other modern wallets implement HD wallets conforming to BIP 32, 43, 44, 49, 84, etc. However, primary users of upstream btcwallet use gRPC-based APIs instead of JSON RPCs. While the wallet application itself and its components support multi-scope (address types) and multi-account, most of the JSON RPCs are half-baked and hard-coded to use only one "default" account and legacy(p2pkh) address type only.
This PR resurrects those accounting RPCs and revives those deprecated fields.
Todo:
For example, without specifying "account," should we return the balance of "all accounts" or "default account"?
It's functioning and in good shape now.
Merge it and work on the remaining tasks on the master branch.