0ae78b1f56
In this commit, we address an issue with the wallet store where it'd be possible for us to keep lingering unconfirmed transaction entries for an output that has been spent by a different, confirmed transaction. This was caused due to us removing all spending transaction entries for a given output when removing conflicts. Since all of the entries would be removed, we weren't able to retrieve the hashes of the remaining spending transactions to remove their records as well. Instead, we propose to only remove the entry for the specified spending transaction.
219 lines
6.6 KiB
Go
219 lines
6.6 KiB
Go
// Copyright (c) 2013-2017 The btcsuite developers
|
|
// Copyright (c) 2015-2016 The Decred developers
|
|
// Use of this source code is governed by an ISC
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package wtxmgr
|
|
|
|
import (
|
|
"github.com/btcsuite/btcd/chaincfg/chainhash"
|
|
"github.com/btcsuite/btcd/wire"
|
|
"github.com/btcsuite/btcwallet/walletdb"
|
|
)
|
|
|
|
// insertMemPoolTx inserts the unmined transaction record. It also marks
|
|
// previous outputs referenced by the inputs as spent.
|
|
func (s *Store) insertMemPoolTx(ns walletdb.ReadWriteBucket, rec *TxRecord) error {
|
|
// Check whether the transaction has already been added to the
|
|
// unconfirmed bucket.
|
|
if existsRawUnmined(ns, rec.Hash[:]) != nil {
|
|
// TODO: compare serialized txs to ensure this isn't a hash
|
|
// collision?
|
|
return nil
|
|
}
|
|
|
|
// Since transaction records within the store are keyed by their
|
|
// transaction _and_ block confirmation, we'll iterate through the
|
|
// transaction's outputs to determine if we've already seen them to
|
|
// prevent from adding this transaction to the unconfirmed bucket.
|
|
for i := range rec.MsgTx.TxOut {
|
|
k := canonicalOutPoint(&rec.Hash, uint32(i))
|
|
if existsRawUnspent(ns, k) != nil {
|
|
return nil
|
|
}
|
|
}
|
|
|
|
log.Infof("Inserting unconfirmed transaction %v", rec.Hash)
|
|
v, err := valueTxRecord(rec)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
err = putRawUnmined(ns, rec.Hash[:], v)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
for _, input := range rec.MsgTx.TxIn {
|
|
prevOut := &input.PreviousOutPoint
|
|
k := canonicalOutPoint(&prevOut.Hash, prevOut.Index)
|
|
err = putRawUnminedInput(ns, k, rec.Hash[:])
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
// TODO: increment credit amount for each credit (but those are unknown
|
|
// here currently).
|
|
|
|
return nil
|
|
}
|
|
|
|
// removeDoubleSpends checks for any unmined transactions which would introduce
|
|
// a double spend if tx was added to the store (either as a confirmed or unmined
|
|
// transaction). Each conflicting transaction and all transactions which spend
|
|
// it are recursively removed.
|
|
func (s *Store) removeDoubleSpends(ns walletdb.ReadWriteBucket, rec *TxRecord) error {
|
|
for _, input := range rec.MsgTx.TxIn {
|
|
prevOut := &input.PreviousOutPoint
|
|
prevOutKey := canonicalOutPoint(&prevOut.Hash, prevOut.Index)
|
|
|
|
doubleSpendHashes := fetchUnminedInputSpendTxHashes(ns, prevOutKey)
|
|
for _, doubleSpendHash := range doubleSpendHashes {
|
|
// We'll make sure not to remove ourselves.
|
|
if rec.Hash == doubleSpendHash {
|
|
continue
|
|
}
|
|
|
|
// If the spending transaction spends multiple outputs
|
|
// from the same transaction, we'll find duplicate
|
|
// entries within the store, so it's possible we're
|
|
// unable to find it if the conflicts have already been
|
|
// removed in a previous iteration.
|
|
doubleSpendVal := existsRawUnmined(
|
|
ns, doubleSpendHash[:],
|
|
)
|
|
if doubleSpendVal == nil {
|
|
continue
|
|
}
|
|
|
|
var doubleSpend TxRecord
|
|
doubleSpend.Hash = doubleSpendHash
|
|
err := readRawTxRecord(
|
|
&doubleSpend.Hash, doubleSpendVal, &doubleSpend,
|
|
)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
log.Debugf("Removing double spending transaction %v",
|
|
doubleSpend.Hash)
|
|
|
|
if err := s.removeConflict(ns, &doubleSpend); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// removeConflict removes an unmined transaction record and all spend chains
|
|
// deriving from it from the store. This is designed to remove transactions
|
|
// that would otherwise result in double spend conflicts if left in the store,
|
|
// and to remove transactions that spend coinbase transactions on reorgs.
|
|
func (s *Store) removeConflict(ns walletdb.ReadWriteBucket, rec *TxRecord) error {
|
|
// For each potential credit for this record, each spender (if any) must
|
|
// be recursively removed as well. Once the spenders are removed, the
|
|
// credit is deleted.
|
|
for i := range rec.MsgTx.TxOut {
|
|
k := canonicalOutPoint(&rec.Hash, uint32(i))
|
|
spenderHashes := fetchUnminedInputSpendTxHashes(ns, k)
|
|
for _, spenderHash := range spenderHashes {
|
|
// If the spending transaction spends multiple outputs
|
|
// from the same transaction, we'll find duplicate
|
|
// entries within the store, so it's possible we're
|
|
// unable to find it if the conflicts have already been
|
|
// removed in a previous iteration.
|
|
spenderVal := existsRawUnmined(ns, spenderHash[:])
|
|
if spenderVal == nil {
|
|
continue
|
|
}
|
|
|
|
var spender TxRecord
|
|
spender.Hash = spenderHash
|
|
err := readRawTxRecord(&spender.Hash, spenderVal, &spender)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
log.Debugf("Transaction %v is part of a removed conflict "+
|
|
"chain -- removing as well", spender.Hash)
|
|
if err := s.removeConflict(ns, &spender); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
if err := deleteRawUnminedCredit(ns, k); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
// If this tx spends any previous credits (either mined or unmined), set
|
|
// each unspent. Mined transactions are only marked spent by having the
|
|
// output in the unmined inputs bucket.
|
|
for _, input := range rec.MsgTx.TxIn {
|
|
prevOut := &input.PreviousOutPoint
|
|
k := canonicalOutPoint(&prevOut.Hash, prevOut.Index)
|
|
err := deleteRawUnminedInput(ns, k, rec.Hash)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return deleteRawUnmined(ns, rec.Hash[:])
|
|
}
|
|
|
|
// UnminedTxs returns the underlying transactions for all unmined transactions
|
|
// which are not known to have been mined in a block. Transactions are
|
|
// guaranteed to be sorted by their dependency order.
|
|
func (s *Store) UnminedTxs(ns walletdb.ReadBucket) ([]*wire.MsgTx, error) {
|
|
recSet, err := s.unminedTxRecords(ns)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
txSet := make(map[chainhash.Hash]*wire.MsgTx, len(recSet))
|
|
for txHash, txRec := range recSet {
|
|
txSet[txHash] = &txRec.MsgTx
|
|
}
|
|
|
|
return DependencySort(txSet), nil
|
|
}
|
|
|
|
func (s *Store) unminedTxRecords(ns walletdb.ReadBucket) (map[chainhash.Hash]*TxRecord, error) {
|
|
unmined := make(map[chainhash.Hash]*TxRecord)
|
|
err := ns.NestedReadBucket(bucketUnmined).ForEach(func(k, v []byte) error {
|
|
var txHash chainhash.Hash
|
|
err := readRawUnminedHash(k, &txHash)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
rec := new(TxRecord)
|
|
err = readRawTxRecord(&txHash, v, rec)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
unmined[rec.Hash] = rec
|
|
return nil
|
|
})
|
|
return unmined, err
|
|
}
|
|
|
|
// UnminedTxHashes returns the hashes of all transactions not known to have been
|
|
// mined in a block.
|
|
func (s *Store) UnminedTxHashes(ns walletdb.ReadBucket) ([]*chainhash.Hash, error) {
|
|
return s.unminedTxHashes(ns)
|
|
}
|
|
|
|
func (s *Store) unminedTxHashes(ns walletdb.ReadBucket) ([]*chainhash.Hash, error) {
|
|
var hashes []*chainhash.Hash
|
|
err := ns.NestedReadBucket(bucketUnmined).ForEach(func(k, v []byte) error {
|
|
hash := new(chainhash.Hash)
|
|
err := readRawUnminedHash(k, hash)
|
|
if err == nil {
|
|
hashes = append(hashes, hash)
|
|
}
|
|
return err
|
|
})
|
|
return hashes, err
|
|
}
|