4656a00705
This changes the database access APIs and each of the "manager" packages (waddrmgr/wstakemgr) so that transactions are opened (only) by the wallet package and the namespace buckets that each manager expects to operate on are passed in as parameters. This helps improve the atomicity situation as it means that many calls to these APIs can be grouped together into a single database transaction. This change does not attempt to completely fix the "half-processed" block problem. Mined transactions are still added to the wallet database under their own database transaction as this is how they are notified by the consensus JSON-RPC server (as loose transactions, without the rest of the block that contains them). It will make updating to a fixed notification model significantly easier, as the same "manager" APIs can still be used, but grouped into a single atomic transaction.
245 lines
7.8 KiB
Go
245 lines
7.8 KiB
Go
// Copyright (c) 2013-2017 The btcsuite developers
|
|
// Copyright (c) 2015-2016 The btcsuite developers
|
|
// Use of this source code is governed by an ISC
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package wallet
|
|
|
|
import (
|
|
"fmt"
|
|
"sort"
|
|
|
|
"github.com/btcsuite/btcd/btcec"
|
|
"github.com/btcsuite/btcd/txscript"
|
|
"github.com/btcsuite/btcd/wire"
|
|
"github.com/btcsuite/btcutil"
|
|
"github.com/btcsuite/btcwallet/waddrmgr"
|
|
"github.com/btcsuite/btcwallet/wallet/txauthor"
|
|
"github.com/btcsuite/btcwallet/walletdb"
|
|
"github.com/btcsuite/btcwallet/wtxmgr"
|
|
)
|
|
|
|
// byAmount defines the methods needed to satisify sort.Interface to
|
|
// sort credits by their output amount.
|
|
type byAmount []wtxmgr.Credit
|
|
|
|
func (s byAmount) Len() int { return len(s) }
|
|
func (s byAmount) Less(i, j int) bool { return s[i].Amount < s[j].Amount }
|
|
func (s byAmount) Swap(i, j int) { s[i], s[j] = s[j], s[i] }
|
|
|
|
func makeInputSource(eligible []wtxmgr.Credit) txauthor.InputSource {
|
|
// Pick largest outputs first. This is only done for compatibility with
|
|
// previous tx creation code, not because it's a good idea.
|
|
sort.Sort(sort.Reverse(byAmount(eligible)))
|
|
|
|
// Current inputs and their total value. These are closed over by the
|
|
// returned input source and reused across multiple calls.
|
|
currentTotal := btcutil.Amount(0)
|
|
currentInputs := make([]*wire.TxIn, 0, len(eligible))
|
|
currentScripts := make([][]byte, 0, len(eligible))
|
|
currentInputValues := make([]btcutil.Amount, 0, len(eligible))
|
|
|
|
return func(target btcutil.Amount) (btcutil.Amount, []*wire.TxIn,
|
|
[]btcutil.Amount, [][]byte, error) {
|
|
|
|
for currentTotal < target && len(eligible) != 0 {
|
|
nextCredit := &eligible[0]
|
|
eligible = eligible[1:]
|
|
nextInput := wire.NewTxIn(&nextCredit.OutPoint, nil, nil)
|
|
currentTotal += nextCredit.Amount
|
|
currentInputs = append(currentInputs, nextInput)
|
|
currentScripts = append(currentScripts, nextCredit.PkScript)
|
|
currentInputValues = append(currentInputValues, nextCredit.Amount)
|
|
}
|
|
return currentTotal, currentInputs, currentInputValues, currentScripts, nil
|
|
}
|
|
}
|
|
|
|
// secretSource is an implementation of txauthor.SecretSource for the wallet's
|
|
// address manager.
|
|
type secretSource struct {
|
|
*waddrmgr.Manager
|
|
addrmgrNs walletdb.ReadBucket
|
|
}
|
|
|
|
func (s secretSource) GetKey(addr btcutil.Address) (*btcec.PrivateKey, bool, error) {
|
|
ma, err := s.Address(s.addrmgrNs, addr)
|
|
if err != nil {
|
|
return nil, false, err
|
|
}
|
|
|
|
mpka, ok := ma.(waddrmgr.ManagedPubKeyAddress)
|
|
if !ok {
|
|
e := fmt.Errorf("managed address type for %v is `%T` but "+
|
|
"want waddrmgr.ManagedPubKeyAddress", addr, ma)
|
|
return nil, false, e
|
|
}
|
|
privKey, err := mpka.PrivKey()
|
|
if err != nil {
|
|
return nil, false, err
|
|
}
|
|
return privKey, ma.Compressed(), nil
|
|
}
|
|
|
|
func (s secretSource) GetScript(addr btcutil.Address) ([]byte, error) {
|
|
ma, err := s.Address(s.addrmgrNs, addr)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
msa, ok := ma.(waddrmgr.ManagedScriptAddress)
|
|
if !ok {
|
|
e := fmt.Errorf("managed address type for %v is `%T` but "+
|
|
"want waddrmgr.ManagedScriptAddress", addr, ma)
|
|
return nil, e
|
|
}
|
|
return msa.Script()
|
|
}
|
|
|
|
// txToOutputs creates a signed transaction which includes each output from
|
|
// outputs. Previous outputs to reedeem are chosen from the passed account's
|
|
// UTXO set and minconf policy. An additional output may be added to return
|
|
// change to the wallet. An appropriate fee is included based on the wallet's
|
|
// current relay fee. The wallet must be unlocked to create the transaction.
|
|
func (w *Wallet) txToOutputs(outputs []*wire.TxOut, account uint32, minconf int32) (tx *txauthor.AuthoredTx, err error) {
|
|
chainClient, err := w.requireChainClient()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
err = walletdb.View(w.db, func(dbtx walletdb.ReadTx) error {
|
|
addrmgrNs := dbtx.ReadBucket(waddrmgrNamespaceKey)
|
|
|
|
// Get current block's height and hash.
|
|
bs, err := chainClient.BlockStamp()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
eligible, err := w.findEligibleOutputs(dbtx, account, minconf, bs)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
inputSource := makeInputSource(eligible)
|
|
changeSource := func() ([]byte, error) {
|
|
// Derive the change output script. As a hack to allow spending from
|
|
// the imported account, change addresses are created from account 0.
|
|
var changeAddr btcutil.Address
|
|
var err error
|
|
if account == waddrmgr.ImportedAddrAccount {
|
|
changeAddr, err = w.NewChangeAddress(0)
|
|
} else {
|
|
changeAddr, err = w.NewChangeAddress(account)
|
|
}
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return txscript.PayToAddrScript(changeAddr)
|
|
}
|
|
tx, err = txauthor.NewUnsignedTransaction(outputs, w.RelayFee(),
|
|
inputSource, changeSource)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// Randomize change position, if change exists, before signing. This
|
|
// doesn't affect the serialize size, so the change amount will still be
|
|
// valid.
|
|
if tx.ChangeIndex >= 0 {
|
|
tx.RandomizeChangePosition()
|
|
}
|
|
|
|
return tx.AddAllInputScripts(secretSource{w.Manager, addrmgrNs})
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
err = validateMsgTx(tx.Tx, tx.PrevScripts, tx.PrevInputValues)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if tx.ChangeIndex >= 0 && account == waddrmgr.ImportedAddrAccount {
|
|
changeAmount := btcutil.Amount(tx.Tx.TxOut[tx.ChangeIndex].Value)
|
|
log.Warnf("Spend from imported account produced change: moving"+
|
|
" %v from imported account into default account.", changeAmount)
|
|
}
|
|
|
|
return tx, nil
|
|
}
|
|
|
|
func (w *Wallet) findEligibleOutputs(dbtx walletdb.ReadTx, account uint32, minconf int32, bs *waddrmgr.BlockStamp) ([]wtxmgr.Credit, error) {
|
|
addrmgrNs := dbtx.ReadBucket(waddrmgrNamespaceKey)
|
|
txmgrNs := dbtx.ReadBucket(wtxmgrNamespaceKey)
|
|
|
|
unspent, err := w.TxStore.UnspentOutputs(txmgrNs)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// TODO: Eventually all of these filters (except perhaps output locking)
|
|
// should be handled by the call to UnspentOutputs (or similar).
|
|
// Because one of these filters requires matching the output script to
|
|
// the desired account, this change depends on making wtxmgr a waddrmgr
|
|
// dependancy and requesting unspent outputs for a single account.
|
|
eligible := make([]wtxmgr.Credit, 0, len(unspent))
|
|
for i := range unspent {
|
|
output := &unspent[i]
|
|
|
|
// Only include this output if it meets the required number of
|
|
// confirmations. Coinbase transactions must have have reached
|
|
// maturity before their outputs may be spent.
|
|
if !confirmed(minconf, output.Height, bs.Height) {
|
|
continue
|
|
}
|
|
if output.FromCoinBase {
|
|
target := int32(w.chainParams.CoinbaseMaturity)
|
|
if !confirmed(target, output.Height, bs.Height) {
|
|
continue
|
|
}
|
|
}
|
|
|
|
// Locked unspent outputs are skipped.
|
|
if w.LockedOutpoint(output.OutPoint) {
|
|
continue
|
|
}
|
|
|
|
// Only include the output if it is associated with the passed
|
|
// account.
|
|
//
|
|
// TODO: Handle multisig outputs by determining if enough of the
|
|
// addresses are controlled.
|
|
_, addrs, _, err := txscript.ExtractPkScriptAddrs(
|
|
output.PkScript, w.chainParams)
|
|
if err != nil || len(addrs) != 1 {
|
|
continue
|
|
}
|
|
addrAcct, err := w.Manager.AddrAccount(addrmgrNs, addrs[0])
|
|
if err != nil || addrAcct != account {
|
|
continue
|
|
}
|
|
eligible = append(eligible, *output)
|
|
}
|
|
return eligible, nil
|
|
}
|
|
|
|
// validateMsgTx verifies transaction input scripts for tx. All previous output
|
|
// scripts from outputs redeemed by the transaction, in the same order they are
|
|
// spent, must be passed in the prevScripts slice.
|
|
func validateMsgTx(tx *wire.MsgTx, prevScripts [][]byte, inputValues []btcutil.Amount) error {
|
|
hashCache := txscript.NewTxSigHashes(tx)
|
|
for i, prevScript := range prevScripts {
|
|
vm, err := txscript.NewEngine(prevScript, tx, i,
|
|
txscript.StandardVerifyFlags, nil, hashCache, int64(inputValues[i]))
|
|
if err != nil {
|
|
return fmt.Errorf("cannot create script engine: %s", err)
|
|
}
|
|
err = vm.Execute()
|
|
if err != nil {
|
|
return fmt.Errorf("cannot validate transaction: %s", err)
|
|
}
|
|
}
|
|
return nil
|
|
}
|