Use Start/End instead of Left/Right to support RTL #1005

Merged

kekkyojin merged 2 commits from rtl-fix into master

2020-09-11 14:28:37 +02:00

kekkyojin commented

2020-09-07 15:20:22 +02:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #999

What is the current behavior?

Code was using API methods which weren't RTL-aware.

What is the new behavior?

Code is using methods and view properties which are RTL-aware

Other information

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #999 ## What is the current behavior? Code was using API methods which weren't RTL-aware. ## What is the new behavior? Code is using methods and view properties which are RTL-aware ## Other information

kauffj commented

2020-09-08 18:23:25 +02:00

(Migrated from github.com)

great fix @kekkyojin!

akinwale commented

2020-09-09 15:06:33 +02:00

(Migrated from github.com)

@kekkyojin This is great, thanks! Is there an easy way to test the RTL display that doesn't involve changing the device language?

kekkyojin commented

2020-09-09 15:23:41 +02:00

(Migrated from github.com)

Sure, @akinwale. On Android Studio, select the Split or the Design view on any layout XML file. Then go to the language selection menu list. That would normally read "Default (en-us)". The last item on the list reads "Preview Right to Left". Views will move to their new positions in real time when selected.

That was the way I tested the second commit on this PR.

akinwale (Migrated from github.com) approved these changes 2020-09-11 14:28:18 +02:00