Add ability to download & delete your own videos and move unpublish button to description #1013

Merged
clay53 merged 1 commit from 987 into master 2020-10-02 12:05:45 +02:00
clay53 commented 2020-09-16 20:36:31 +02:00 (Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: #987

What is the current behavior?

Inability to download your own videos.

What is the new behavior?

The ability to download new videos. Due to the old reuse of the delete action for both deleting from files and unpublishing, a distinction had to be made if both were to be possible. So, I put an unpublish button in the description (since it wouldn't fit in the current actions area) and removed the ability to unpublish from the old delete button.

## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #987 ## What is the current behavior? Inability to download your own videos. ## What is the new behavior? The ability to download new videos. Due to the old reuse of the delete action for both deleting from files and unpublishing, a distinction had to be made if both were to be possible. So, I put an unpublish button in the description (since it wouldn't fit in the current actions area) and removed the ability to unpublish from the old delete button.
akinwale commented 2020-09-29 20:07:43 +02:00 (Migrated from github.com)

Hey, thanks for this PR. Will check it out and give feedback.

Hey, thanks for this PR. Will check it out and give feedback.
akinwale (Migrated from github.com) approved these changes 2020-10-02 12:05:31 +02:00
akinwale (Migrated from github.com) left a comment

Looks good. Thanks!

Looks good. Thanks!
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#1013
No description provided.