fix issue 1040 #1041

Merged
ycohen-dev merged 1 commit from fix_issue_1040 into master 2020-10-21 01:15:37 +02:00
ycohen-dev commented 2020-10-17 21:31:26 +02:00 (Migrated from github.com)

Transaction amount text Direction changed to LTR.
Transaction amount pinned to end of view

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: 1040

What is the current behavior?

RTL layouts displaying negative transaction amounts with misplaced sign as (amount)(minus)

What is the new behavior?

RTL layouts displaying negative transaction amounts as (minus)(amount)

Screenshots

LTR layout after fix

Stable - not modifed
negative_amount_fix_ltr

RTL layout afer fix

Fixed
negative_amount_fix_rtl
(Ignore separate RTL UI issues - further fixes in other PR's)

Other information

Pure numeric texts should always be LTR text direction

Transaction amount text Direction changed to LTR. Transaction amount pinned to end of view ## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: 1040 ## What is the current behavior? RTL layouts displaying negative transaction amounts with misplaced sign as (amount)(minus) ## What is the new behavior? RTL layouts displaying negative transaction amounts as (minus)(amount) ## Screenshots ### LTR layout after fix Stable - not modifed ![negative_amount_fix_ltr](https://user-images.githubusercontent.com/33922624/96352672-a6efb700-10cd-11eb-975c-57f11d840a4a.jpg) ### RTL layout afer fix Fixed ![negative_amount_fix_rtl](https://user-images.githubusercontent.com/33922624/96352702-f635e780-10cd-11eb-927e-dce38180771b.jpg) (Ignore separate RTL UI issues - further fixes in other PR's) ## Other information Pure numeric texts should always be LTR text direction <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->
mymage (Migrated from github.com) approved these changes 2020-10-18 12:06:09 +02:00
mymage (Migrated from github.com) left a comment

For me is functionally ok

For me is functionally ok
akinwale (Migrated from github.com) approved these changes 2020-10-21 01:15:31 +02:00
akinwale (Migrated from github.com) left a comment

Looks good to me.

Looks good to me.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#1041
No description provided.