Fix floating wallet/rewards bar for RTL layout #1044

Merged

ycohen-dev merged 1 commit from fix_issue_1043 into master

2020-10-23 14:25:08 +02:00

ycohen-dev commented

2020-10-21 20:57:15 +02:00

(Migrated from github.com)

Floating wallet balance/rewards now visible in RTL layout

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #1043

What is the current behavior?

Floating wallet fragment pinned to the bottom right of the screen (regardless of layout direction)
Floating wallet fragment does not display wallet balance on RTL layout

What is the new behavior?

Floating wallet fragment pinned to the bottom end of the screen - generalized LTR/RTL solution
Floating wallet fragment now displays both rewards and balance

Screenshots

LTR layout after fix

Not modified

RTL layout after fix

Fixed

Disclaimer

I swear I'm not splitting every little RTL issue to separate PR's
I'm genuinely finding them one at a time 🤷

Floating wallet balance/rewards now visible in RTL layout ## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #1043 ## What is the current behavior? Floating wallet fragment pinned to the bottom right of the screen (regardless of layout direction) Floating wallet fragment does not display wallet balance on RTL layout ## What is the new behavior? Floating wallet fragment pinned to the bottom end of the screen - generalized LTR/RTL solution Floating wallet fragment now displays both rewards and balance ## Screenshots ### LTR layout after fix Not modified ![bug_floating_fixed_ltr](https://user-images.githubusercontent.com/33922624/96769327-a2860f80-13e7-11eb-95a1-7647040014cb.jpg) ### RTL layout after fix Fixed ![bug_floating_fixed_rtl](https://user-images.githubusercontent.com/33922624/96769268-8edaa900-13e7-11eb-814f-8c8e40154cdc.jpg) ## Disclaimer I swear I'm not splitting every little RTL issue to separate PR's I'm genuinely finding them one at a time 🤷

kekkyojin commented

2020-10-21 21:32:40 +02:00

(Migrated from github.com)

Could you use descriptive commit messages for what they do instead of what fixes on the GitHub repository? Thanks.

ycohen-dev commented

2020-10-22 04:38:50 +02:00

(Migrated from github.com)

@kekkyojin
The PR is not descriptive - the commit message is actually
Floating wallet balance/rewards now visible in RTL layout
Do you want me to close this PR and reopen under a descriptive name?

@kekkyojin The PR is not descriptive - the commit message is actually `Floating wallet balance/rewards now visible in RTL layout` Do you want me to close this PR and reopen under a descriptive name?

kekkyojin commented

2020-10-22 12:10:49 +02:00

(Migrated from github.com)

@kekkyojin
The PR is not descriptive - the commit message is actually
Floating wallet balance/rewards now visible in RTL layout

Problem is GitHub only shows first paragraph of commit message. Also, when looking at the Annotate feature on Android Studio or doing a 'git log', it will be needed to read a longer text when searching for a specific change explanation. I suggest you to at least put the descriptive change into the first paragraph and then anything else.

Do you want me to close this PR and reopen under a descriptive name?

No, it was not necessary.

> @kekkyojin > The PR is not descriptive - the commit message is actually > `Floating wallet balance/rewards now visible in RTL layout` Problem is GitHub only shows first paragraph of commit message. Also, when looking at the Annotate feature on Android Studio or doing a 'git log', it will be needed to read a longer text when searching for a specific change explanation. I suggest you to at least put the descriptive change into the first paragraph and then anything else. > Do you want me to close this PR and reopen under a descriptive name? No, it was not necessary.

ycohen-dev commented

2020-10-22 21:28:29 +02:00

(Migrated from github.com)

Commit message is now descriptive first, referencing issue second - thus showing fine in git log and android studio.

👍 1

akinwale (Migrated from github.com) approved these changes 2020-10-23 14:24:59 +02:00