Offer opening unsupported filetypes with external app #1045

Merged

kekkyojin merged 1 commit from open-file-external into master

2020-11-13 15:42:59 +01:00

kekkyojin commented

2020-10-27 14:56:11 +01:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #419

What is the current behavior?

If LBRY doesn't include the capacity of showing the content on the claim, user should download file and search for it on its device and then open it

What is the new behavior?

User is shown a notice about LBRY inability to show content and a button which allows it to choose a compatible app when clicked.

Other information

This PR adds a new string and reuses other one.

In order to test it, reviewer could search for "PDF" on LBRY Android and look for one without a time on the snapshot. I used the ones with "UOC" on their title. "UOC PDF" could be a better approach for the search text.

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #419 ## What is the current behavior? If LBRY doesn't include the capacity of showing the content on the claim, user should download file and search for it on its device and then open it ## What is the new behavior? User is shown a notice about LBRY inability to show content and a button which allows it to choose a compatible app when clicked. ## Other information This PR adds a new string and reuses other one. In order to test it, reviewer could search for "PDF" on LBRY Android and look for one without a time on the snapshot. I used the ones with "UOC" on their title. "UOC PDF" could be a better approach for the search text.

akinwale (Migrated from github.com) approved these changes 2020-11-13 15:42:50 +01:00