Sort replies from oldest to newest #1057

Merged

kekkyojin merged 1 commit from sort-commentreplies into master

2020-12-05 04:32:41 +01:00

kekkyojin commented

2020-12-01 04:51:10 +01:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #948

What is the current behavior?

Replies to comments are ordered in a way which newest ones appear first, making difficult to follow the conversation if there are lots of replies, as it requires to scroll down to the latest one and then scrolling up while reading adn then scrolling down again to read next comment.

What is the new behavior?

Replies are ordered on its chronological order: older are shown first and followed by newer ones.

New behavior is also consistent with LBRY.TV and ODYSEE.COM. See for example https://lbry.tv/microsoft:2. Replies from the comments are the bottom are now shown in the same order in both the site and LBRY Android app.

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #948 ## What is the current behavior? Replies to comments are ordered in a way which newest ones appear first, making difficult to follow the conversation if there are lots of replies, as it requires to scroll down to the latest one and then scrolling up while reading adn then scrolling down again to read next comment. ## What is the new behavior? Replies are ordered on its chronological order: older are shown first and followed by newer ones. New behavior is also consistent with LBRY.TV and ODYSEE.COM. See for example https://lbry.tv/microsoft:2. Replies from the comments are the bottom are now shown in the same order in both the site and LBRY Android app.

kauffj commented

2020-12-04 16:41:41 +01:00

(Migrated from github.com)

Review coming soon! Thank you

akinwale (Migrated from github.com) approved these changes 2020-12-05 04:32:33 +01:00