Use ListView to show startup stage errors #1061

Merged
kekkyojin merged 1 commit from startupstage-listview into master 2020-12-12 23:16:18 +01:00
kekkyojin commented 2020-12-09 21:17:54 +01:00 (Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number:

What is the current behavior?

It uses views on the activity. These views should be loaded into memory even if they are not displayed.

What is the new behavior?

These views will be created on the fly only when required. After screenshooting the activity before and after applying these changes, the screen seems exactly the same.

Other information

Testing: Fully close the app and the background service notification, activate airplane mode on the device and then restart the app.

## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [x] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: ## What is the current behavior? It uses views on the activity. These views should be loaded into memory even if they are not displayed. ## What is the new behavior? These views will be created on the fly only when required. After screenshooting the activity before and after applying these changes, the screen seems exactly the same. ## Other information Testing: Fully close the app and the background service notification, activate airplane mode on the device and then restart the app. <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->
akinwale commented 2020-12-10 09:58:33 +01:00 (Migrated from github.com)

Hey. This is cool, thanks. Will review today.

Hey. This is cool, thanks. Will review today.
akinwale (Migrated from github.com) approved these changes 2020-12-12 23:16:08 +01:00
akinwale (Migrated from github.com) left a comment

This is much cleaner! Thanks. 👍

This is much cleaner! Thanks. :+1:
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#1061
No description provided.