Linting errors hinder ability to build repository #1064

New issue

Open

opened 2020-12-13 02:43:06 +01:00 by clay53 · 4 comments

clay53 commented

2020-12-13 02:43:06 +01:00

(Migrated from github.com)

The Issue

I keep getting linting errors when trying to build this app. I'm fairly sure it's not just me. This forces me to have to put lintOptions { abortOnError false } in the android options of app/build.gradle to be able to build and install the app. Can these issues be fixed or should this workaround be added to source?

Steps to reproduce

Clone repo
Open it in Android Studio
Set up stuff
Try to run

Expected behaviour

I should be able to build the project without having to do a workaround.

Actual behaviour

I have to do a workaround so I can build the project.

System Configuration

Device: pop!os latest

Screenshots

html file of errors included as .txt file (to make github happy)
lint-results.txt

Acceptance Criteria

Workaround added to source OR linting errors fixed

## The Issue I keep getting linting errors when trying to build this app. I'm fairly sure it's not just me. This forces me to have to put `lintOptions { abortOnError false }` in the `android` options of `app/build.gradle` to be able to build and install the app. Can these issues be fixed or should this workaround be added to source? ### Steps to reproduce 1. Clone repo 2. Open it in Android Studio 3. Set up stuff 4. Try to run ### Expected behaviour I should be able to build the project without having to do a workaround. ### Actual behaviour I have to do a workaround so I can build the project. ## System Configuration - Device: pop!os latest ## Screenshots  html file of errors included as .txt file (to make github happy) [lint-results.txt](https://github.com/lbryio/lbry-android/files/5684054/lint-results.txt) ### Acceptance Criteria 1. Workaround added to source OR linting errors fixed

kekkyojin commented

2020-12-13 13:36:27 +01:00

(Migrated from github.com)

These warnings aren't making impossible to build, though.

The only problem I have when building is that I have to disable every line related to GMS on app/build.gradle and add a twitter.properties file which shouldn't be added to any commit.

I am currently working on fixing linter warnings for some files, beginning with MainActivity, as they make very hard to see other markers on the scroll bar. I am doing it on a git branch and from time to time, as it es not going to fix any bug. These warnings aren't making impossible to build, though. The only problem I have when building is that I have to disable every line related to GMS on app/build.gradle and add a twitter.properties file which shouldn't be added to any commit.

clay53 commented

2020-12-14 18:34:38 +01:00

(Migrated from github.com)

I am currently working on fixing linter warnings for some files, beginning with MainActivity, as they make very hard to see other markers on the scroll bar. I am doing it on a git branch and from time to time, as it es not going to fix any bug.

These warnings aren't making impossible to build, though.

The only problem I have when building is that I have to disable every line related to GMS on app/build.gradle and add a twitter.properties file which shouldn't be added to any commit.

Removing lines related to GMS did not change me having to disable linting error aborts. I've never have issues related to GMS before so I'm not sure what's happening here.

> I am currently working on fixing linter warnings for some files, beginning with MainActivity, as they make very hard to see other markers on the scroll bar. I am doing it on a git branch and from time to time, as it es not going to fix any bug. > > These warnings aren't making impossible to build, though. > > The only problem I have when building is that I have to disable every line related to GMS on app/build.gradle and add a twitter.properties file which shouldn't be added to any commit. Removing lines related to GMS did not change me having to disable linting error aborts. I've never have issues related to GMS before so I'm not sure what's happening here.

clay53 commented

2020-12-14 19:03:10 +01:00

(Migrated from github.com)

I called out the missing twitter.properties file in the instructions in #997 but it seems that it hasn't been fixed yet.