Styling <code> tag for Markdown content #1123

Merged

kekkyojin merged 1 commit from style-code-tag into master

2021-02-16 16:59:37 +01:00

kekkyojin commented

2021-01-21 00:42:55 +01:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix

Fixes

Issue Number: #960 -partial fix, don't close-

What is the current behavior?

<code> tag is not rendered like on LBRY Desktop or alternative websites

What is the new behavior?

<code> tag is now rendered like in the desktop app, both in light and dark theme.

Other information

CommonMark offers the possibility of adding attributes to a node. I think this is the way it should be done, instead of embedding the CSS. This way, style is only added when needed. Code to add the style to every tag is only run when required.

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix ## Fixes Issue Number: #960 -partial fix, don't close- ## What is the current behavior? `<code>` tag is not rendered like on LBRY Desktop or alternative websites ## What is the new behavior? `<code>` tag is now rendered like in the desktop app, both in light and dark theme. ## Other information CommonMark offers the possibility of adding attributes to a node. I think this is the way it should be done, instead of embedding the CSS. This way, style is only added when needed. Code to add the style to every tag is only run when required.

kauffj commented

2021-02-15 20:40:53 +01:00

(Migrated from github.com)

I think this was missed. We intend to address PRs promptly. If it's ever longer than 1 week do not hesitate to ping us @kekkyojin.

akinwale (Migrated from github.com) approved these changes 2021-02-16 16:58:48 +01:00