Add unit test for LbryUri.toTvString #1135

Merged
kekkyojin merged 1 commit from totvstring-unittest into master 2021-02-22 20:07:55 +01:00
kekkyojin commented 2021-02-16 16:47:16 +01:00 (Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe: Unit test

Fixes

Issue Number:

What is the current behavior?

LbryUri.toTvString() lacks its unit test

What is the new behavior?

Now it ill be possible to test for method to do what it is supposed to do

Other information

This is related to #1126, but it is not a fix for it. Providing a fix would then not need to run the app on an emulator, as it will only be needed to run the test, which can be done just with the Java Virtual Machine.

## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [x] Other - Please describe: Unit test ## Fixes Issue Number: ## What is the current behavior? LbryUri.toTvString() lacks its unit test ## What is the new behavior? Now it ill be possible to test for method to do what it is supposed to do ## Other information This is related to #1126, but it is not a fix for it. Providing a fix would then not need to run the app on an emulator, as it will only be needed to run the test, which can be done just with the Java Virtual Machine. <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->
akinwale (Migrated from github.com) approved these changes 2021-02-22 20:07:49 +01:00
akinwale (Migrated from github.com) left a comment

Looks good. Thanks.

Looks good. Thanks.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#1135
No description provided.