Use commentron instead of Comment SDK calls #1149

Merged

kekkyojin merged 2 commits from interacting-comment-servers into master

2021-02-24 16:23:34 +01:00

kekkyojin commented

2021-02-23 18:54:42 +01:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #1131

What is the current behavior?

Any action related to comments is performed through SDK

What is the new behavior?

App uses SDK only to sign parameters with the channel private key. Everything is performed by making requests directly to Comment Server -aka Commentron-.

Other information

Currently app is lacking the capability of removing or editing comments. That features has not been added on this PR.

A new Comments class has been added on the utils package; it will act as a 'Helper'.

From the issue description, it seems that the user could change the server it wanted to use for commenting, so a generic performRequest() is included, but it is currently been called with the default server as a parameter.

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [x] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #1131 ## What is the current behavior? Any action related to comments is performed through SDK ## What is the new behavior? App uses SDK only to sign parameters with the channel private key. Everything is performed by making requests directly to Comment Server -aka Commentron-. ## Other information Currently app is lacking the capability of removing or editing comments. That features has not been added on this PR. A new `Comments` class has been added on the utils package; it will act as a 'Helper'. From the issue description, it seems that the user could change the server it wanted to use for commenting, so a generic performRequest() is included, but it is currently been called with the default server as a parameter.

akinwale (Migrated from github.com) approved these changes 2021-02-24 13:22:07 +01:00

akinwale (Migrated from github.com) left a comment

Just one minor change. Everything else looks good.

app/src/main/java/io/lbry/browser/utils/Comments.java

akinwale (Migrated from github.com) commented

2021-02-24 13:21:51 +01:00

I think you can just use the current timestamp as the id here. Although we're not tracing request JSON RPC request IDs at the moment, we may want to in the future.