Extract dimension values into resource files

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#1151

kekkyojin commented

2021-02-24 15:14:05 +01:00

(Migrated from github.com)

The Issue

Most layouts are using hard-coded dimension values and font sizes. Although this is not a problem with current layouts, as they are not optimized for any screen size/pixel density, in order to improve how app looks in larger screen devices -like tablets and TVs-, it helps to be able to set those dimensions accordingly instead of having to duplicate layouts and changing the hard-coded dimensions on the new ones.

Steps to reproduce

Open the app on different screen density devices

Expected behaviour

Layout is optimized

Actual behaviour

Tell us what happeEverything looks wrong, specifically text size, which seems too much small on larger screen devices, wasting a lot of space

#693 and #798

Internal Use

Acceptance Criteria

Definition of Done

Tested against acceptance criteria
Tested against the assumptions of the user story
The project builds without errors
Unit tests are written and passing
Tests on devices/browsers listed in the issue have passed
QA performed & issues resolved
Refactoring completed
Any configuration or build changes documented
Documentation updated
Peer Code Review performed

## The Issue Most layouts are using hard-coded dimension values and font sizes. Although this is not a problem with current layouts, as they are not optimized for any screen size/pixel density, in order to improve how app looks in larger screen devices -like tablets and TVs-, it helps to be able to set those dimensions accordingly instead of having to duplicate layouts and changing the hard-coded dimensions on the new ones. ### Steps to reproduce 1. Open the app on different screen density devices ### Expected behaviour Layout is optimized ### Actual behaviour Tell us what happeEverything looks wrong, specifically text size, which seems too much small on larger screen devices, wasting a lot of space ### Related Issues #693 and #798 ## Internal Use ### Acceptance Criteria 1. 2. 3. ### Definition of Done - [ ] Tested against acceptance criteria - [ ] Tested against the assumptions of the user story - [ ] The project builds without errors - [ ] Unit tests are written and passing - [ ] Tests on devices/browsers listed in the issue have passed - [ ] QA performed & issues resolved - [ ] Refactoring completed - [ ] Any configuration or build changes documented - [ ] Documentation updated - [ ] Peer Code Review performed

Extract dimension values into resource files #1151