Hide support button and comments consistently with claim tags #1152

Merged

kekkyojin merged 2 commits from support-tags-ui-consistency into master

2021-02-26 19:31:11 +01:00

kekkyojin commented

2021-02-24 16:05:37 +01:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number:1146

What is the current behavior?

See #1146

What is the new behavior?

See #1146

Other information

In comment fragment for channel, the comment form visibility is GONE to avoid it been shown just before being replaced by the texto for channels having comments disabled. This change is not needed for FileViewFragment as this replacement occurs while not in user view.

Two new strings have been added. Text was taken from LBRY.TV. Translation will be needed.

This commit adds code to code which is already been duplicated in various files. This will be fixed in an upcoming PR which replaces comment form with a new widget instead of a layout which should be

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number:1146 ## What is the current behavior? See #1146 ## What is the new behavior? See #1146 ## Other information In comment fragment for channel, the comment form visibility is GONE to avoid it been shown just before being replaced by the texto for channels having comments disabled. This change is not needed for FileViewFragment as this replacement occurs while not in user view. Two new strings have been added. Text was taken from LBRY.TV. Translation will be needed. This commit adds code to code which is already been duplicated in various files. This will be fixed in an upcoming PR which replaces comment form with a new widget instead of a layout which should be <included>

kekkyojin commented

2021-02-24 16:19:28 +01:00

(Migrated from github.com)

Known problem: on content view, the text explaining that comments have been disabled by the author, wallet and rewards bubble is positioned just above it, so the string is not visible on its full length. It will fixed for #1054 very shortly.