Move the wallet floating button away when scroll gets to the bottom #1155

Merged

kekkyojin merged 1 commit from floating-balance-oculting into master

2021-03-04 19:11:19 +01:00

kekkyojin commented

2021-03-02 17:20:37 +01:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: partially #1054 (DON'T CLOSE)

What is the current behavior?

Latest comment or text cannot be read at the bottom of the fragment which shows the content (FileViewFragment)

What is the new behavior?

Floating balance container will be animated to disappear to the bottom of the screen when user has scroll to the bottom of the screen. When there are no comments and last item is the comment form, the balance will not be animated, as there is enough room to see and interact with the form.

When user scrolls some distance in the upward direction, balance container will be animated again into the screen.

Other information

The same fix can be applied to channel screen. This will come in another PR, as it requires more time because of the way tabs work in Android

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: partially #1054 (DON'T CLOSE) ## What is the current behavior? Latest comment or text cannot be read at the bottom of the fragment which shows the content (FileViewFragment) ## What is the new behavior? Floating balance container will be animated to disappear to the bottom of the screen when user has scroll to the bottom of the screen. When there are no comments and last item is the comment form, the balance will not be animated, as there is enough room to see and interact with the form. When user scrolls some distance in the upward direction, balance container will be animated again into the screen. ## Other information The same fix can be applied to channel screen. This will come in another PR, as it requires more time because of the way tabs work in Android

akinwale (Migrated from github.com) approved these changes 2021-03-04 09:51:52 +01:00