Use total wallet balance instead of spendable #1162

Merged

kekkyojin merged 1 commit from wallet-total into master

2021-03-16 09:22:58 +01:00

kekkyojin commented

2021-03-08 18:59:27 +01:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #1147

What is the current behavior?

Spendable wallet balance is shown instead of total one

What is the new behavior?

Now total wallet balance will be shown. Also the breakdown is shown in a expandable view which will animate a little bit when expanding.

Other information

A new custom view to show LBRY Credits has been created. This is mostly only usable on the wallet fragment, but it reduces complexity on the layout files as they only need a single widget to be added or edited instead of a couple of them. Also the view can now be edited only once and will be updated wherever it would be used.

Balance breakdown has been implemented as a listview. This way, new items can be added as a Java object instead of using hard-coded views on the balance layout.

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #1147 ## What is the current behavior? Spendable wallet balance is shown instead of total one ## What is the new behavior? Now total wallet balance will be shown. Also the breakdown is shown in a expandable view which will animate a little bit when expanding. ## Other information A new custom view to show LBRY Credits has been created. This is mostly only usable on the wallet fragment, but it reduces complexity on the layout files as they only need a single widget to be added or edited instead of a couple of them. Also the view can now be edited only once and will be updated wherever it would be used. Balance breakdown has been implemented as a listview. This way, new items can be added as a Java object instead of using hard-coded views on the balance layout.

kekkyojin commented

2021-03-10 00:58:18 +01:00

(Migrated from github.com)

There is a UI problem when unlocking tips, @akinwale . This code unlocks tips even when there were more than 400, but UI is not updated accordingly as expected.

Don't review it yet.

There is a UI problem when unlocking tips, @akinwale . This code unlocks tips even when there were more than 400, but UI is not updated accordingly as expected. Don't review it yet.

akinwale (Migrated from github.com) approved these changes 2021-03-16 09:10:21 +01:00