Enable phone verification #1168

Merged

kekkyojin merged 1 commit from enable-phone-verification into master

2021-03-16 09:22:36 +01:00

kekkyojin commented

2021-03-11 18:04:06 +01:00

(Migrated from github.com)

Show the Close button after phone number has been verified

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

Feature
Code style update (formatting)

Fixes

Issue Number: #1085

What is the current behavior?

No way to verify account other than Twitter, Discord chat or paying fee

What is the new behavior?

Now it is also possible to be verified using the user mobile phone number

Other information

This PR adds some strings which should be translated.

Adds a button to the manual verification fragment. When user clicks on it, a new fragment shows, asking user to introduce its phone number. Then a SMS is send to it, which user should introduce inte the fragment. If it matches, the fragment closes. Until #1167 is fixed, the next fragment shown to user is the verification fragment again.

This PR also re-activates the onBackPressed() callback, to allow user to go back when Verifying Phone Number fragment is in the foreground. The cross image will close the full verification fragment. User would prefer to go from one method to another one -from mobile phone to Twitter account, for example-.

Show the Close button after phone number has been verified ## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change ## PR Type What kind of change does this PR introduce? - [x] Feature - [x] Code style update (formatting) ## Fixes Issue Number: #1085 ## What is the current behavior? No way to verify account other than Twitter, Discord chat or paying fee ## What is the new behavior? Now it is also possible to be verified using the user mobile phone number ## Other information This PR adds some strings which should be translated. Adds a button to the manual verification fragment. When user clicks on it, a new fragment shows, asking user to introduce its phone number. Then a SMS is send to it, which user should introduce inte the fragment. If it matches, the fragment closes. Until #1167 is fixed, the next fragment shown to user is the verification fragment again. This PR also re-activates the onBackPressed() callback, to allow user to go back when Verifying Phone Number fragment is in the foreground. The cross image will close the full verification fragment. User would prefer to go from one method to another one -from mobile phone to Twitter account, for example-.

akinwale (Migrated from github.com) approved these changes 2021-03-16 09:18:41 +01:00