Use ':' as separator for LBRY.TV sharing links #1169

Merged
kekkyojin merged 1 commit from sharing-link into master 2021-03-15 16:22:18 +01:00
kekkyojin commented 2021-03-11 18:24:54 +01:00 (Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

  • Bugfix

Fixes

Issue Number: #1126

What is the current behavior?

Unit test for toTvString() fails

What is the new behavior?

Unit test for toTvString() no longer fails. This is the method used for getting a sharing link, so when the unit test succeeds, the sharing link should be ok

## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change ## PR Type What kind of change does this PR introduce? - [x] Bugfix ## Fixes Issue Number: #1126 ## What is the current behavior? Unit test for toTvString() fails ## What is the new behavior? Unit test for toTvString() no longer fails. This is the method used for getting a sharing link, so when the unit test succeeds, the sharing link should be ok
akinwale (Migrated from github.com) approved these changes 2021-03-15 16:00:56 +01:00
akinwale (Migrated from github.com) left a comment

Looks good. Thanks.

Looks good. Thanks.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#1169
No description provided.