Notification improvements #1175

Merged

kekkyojin merged 3 commits from notification-improvements into master

2021-03-29 17:39:28 +02:00

kekkyojin commented

2021-03-16 22:42:11 +01:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

Bugfix

Fixes

Issue Number: #1142 DON'T CLOSE

What is the current behavior?

What is the new behavior?

Other information

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change ## PR Type What kind of change does this PR introduce? - [x] Bugfix ## Fixes Issue Number: #1142 DON'T CLOSE ## What is the current behavior? ## What is the new behavior? ## Other information

akinwale (Migrated from github.com) approved these changes 2021-03-19 10:33:36 +01:00

app/src/main/java/io/lbry/browser/MainActivity.java

akinwale (Migrated from github.com) commented

2021-03-19 10:33:30 +01:00

I used the back stack entry count here because not all the fragments we display are added to the back stack. If you're 100% sure this will still work regardless, then this is ok. Everything else looks good.

kekkyojin (Migrated from github.com) reviewed 2021-03-19 12:17:45 +01:00

app/src/main/java/io/lbry/browser/MainActivity.java

kekkyojin (Migrated from github.com) commented

2021-03-19 12:17:44 +01:00

I tested this new code for this bug, but not in other conditions. I will be debugging it for longer and commit and request another review if needed.

That part of the code was giving me problems because after the first time I clicked on a notification and wanted to view some other content, there was a silent IndexOutOfBoundsException. I think that silent exception -I mean, catched, but nothing else- could be related to notification items not working when clicked. I tested this new code for this bug, but not in other conditions. I will be debugging it for longer and commit and request another review if needed.

kekkyojin (Migrated from github.com) reviewed 2021-03-19 12:57:24 +01:00

app/src/main/java/io/lbry/browser/MainActivity.java

kekkyojin (Migrated from github.com) commented

2021-03-19 12:57:24 +01:00

Latest commit 96606f5 simplifies getting the fragment which is currently on main activity by querying the OS for it. Main activity is using a frame layout as a parent layout where fragments can be added. That allows app to simply request which fragment is there, instead of travelling the backstack or the list of fragments.

Latest commit 96606f5 simplifies getting the fragment which is currently on main activity by querying the OS for it. Main activity is using a frame layout as a parent layout where fragments can be added. That allows app to simply request which fragment is there, instead of travelling the backstack or the list of fragments.