Added QR scanner to wallet send card #1194

2021-05-26T09:58:04+02:00

soup-jingle commented

2021-05-26 09:58:04 +02:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #202

What is the current behavior?

There is no QR scanner for sending funds to an address encoded as a QR code.

What is the new behavior?

In the Wallet's Send card, there is now QR scanning functionality which will fill the recipient address with the value the scanner gets.

Other information

The QR library (zxing 4.1.0) works on SDK 24 and up, but I added a 'fallback' for 3.3.0 as they advise so the minimum SDK of 21 should still work and be able to use the functionality. I was not, however, able to test this on any devices with that SDK version.

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ ] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #202 ## What is the current behavior? There is no QR scanner for sending funds to an address encoded as a QR code. ## What is the new behavior? In the Wallet's Send card, there is now QR scanning functionality which will fill the recipient address with the value the scanner gets. ## Other information The QR library (zxing 4.1.0) works on SDK 24 and up, but I added a 'fallback' for 3.3.0 as they advise so the minimum SDK of 21 should still work and be able to use the functionality. I was not, however, able to test this on any devices with that SDK version.

kekkyojin (Migrated from github.com) reviewed 2021-05-26 16:19:17 +02:00

kekkyojin (Migrated from github.com) left a comment

Not a formal review, but these code style changes would be required

kekkyojin (Migrated from github.com) reviewed 2021-05-26 16:20:35 +02:00

app/build.gradle

kekkyojin (Migrated from github.com) commented

2021-05-26 16:20:34 +02:00

Revert this change

kekkyojin (Migrated from github.com) reviewed 2021-05-26 16:21:39 +02:00

app/src/main/java/io/lbry/browser/ui/wallet/WalletFragment.java

kekkyojin (Migrated from github.com) commented

2021-05-26 16:21:38 +02:00

Revert the changes on these lines

kekkyojin (Migrated from github.com) reviewed 2021-05-26 16:22:23 +02:00

app/src/main/java/io/lbry/browser/ui/wallet/WalletFragment.java

kekkyojin (Migrated from github.com) commented

2021-05-26 16:22:23 +02:00

Revert the change on this last line 824

kekkyojin (Migrated from github.com) reviewed 2021-05-26 16:23:01 +02:00

app/src/main/res/drawable-anydpi/ic_qr_scanner.xml

					
				@ -0,0 +5,4 @@

				    android:viewportHeight="24"

				    android:tint="?attr/colorControlNormal">

				  <path

				      android:fillColor="@android:color/white"

kekkyojin (Migrated from github.com) commented

2021-05-26 16:23:01 +02:00

Have you tested this on a device or emulator on dark theme mode?

tzarebczan commented

2021-05-27 01:50:13 +02:00

(Migrated from github.com)

Thanks so much for the PR! We'll get another closer review on it soon.

Can we show you some appreciation?

Thanks so much for the PR! We'll get another closer review on it soon. Can we show you some [appreciation](https://lbry.com/faq/appreciation)?

kekkyojin (Migrated from github.com) reviewed 2021-07-28 22:47:40 +02:00

app/src/main/res/drawable-anydpi/ic_qr_scanner.xml

					
				@ -0,0 +5,4 @@

				    android:viewportHeight="24"

				    android:tint="?attr/colorControlNormal">

				  <path

				      android:fillColor="@android:color/white"

kekkyojin (Migrated from github.com) commented

2021-07-28 22:47:40 +02:00

I have tested it on Android 8.1. That API Level doesn't support dark mode, but enabling dark mode on app settings does the same.

Button image is still visible, so this conversation can be resolved.

I have tested it on Android 8.1. That API Level doesn't support dark mode, but enabling dark mode on app settings does the same. Button image is still visible, so this conversation can be resolved.

kekkyojin (Migrated from github.com) approved these changes 2021-07-28 23:00:37 +02:00

kekkyojin (Migrated from github.com) left a comment

I have tested this. It works as expected. I does decode a LBRY Credits address and writes it on the expected field.

In order to test this, it was needed to merge changes from master branch. The parent commit PR author branched from was using a repository for AAR which is no longer working. That was fixed on master. After merging master into PR branch, this will build without a problem.

I have tested this. It works as expected. I does decode a LBRY Credits address and writes it on the expected field. In order to test this, it was needed to merge changes from master branch. The parent commit PR author branched from was using a repository for AAR which is no longer working. That was fixed on master. After merging master into PR branch, this will build without a problem.

akinwale (Migrated from github.com) approved these changes 2021-08-13 10:01:37 +02:00

Sign in to join this conversation.

No reviewers

kekkyojin

akinwale