Accept colon or octoshape as claimID modifier character #1208

Merged
kekkyojin merged 1 commit from claimid-modifier-char into master 2021-08-11 11:20:58 +02:00
kekkyojin commented 2021-07-29 01:04:27 +02:00 (Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: #1053

What is the current behavior?

It replaces colon with octoshape character

What is the new behavior?

Accepts both colon and octoshape as modifiers for claimIDs while changing accepted sequence number modifier to an asterisk as noted on spec.lbry.com URL section

## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #1053 ## What is the current behavior? It replaces colon with octoshape character ## What is the new behavior? Accepts both colon and octoshape as modifiers for claimIDs while changing accepted sequence number modifier to an asterisk as noted on spec.lbry.com URL section
akinwale (Migrated from github.com) approved these changes 2021-08-11 11:20:47 +02:00
akinwale (Migrated from github.com) left a comment

Looks good. Thanks.

Looks good. Thanks.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#1208
No description provided.