LBRYCommunity/lbry-android
1
0
Fork 0
Code Issues 155 Pull requests 6 Projects Releases 84 Packages Wiki Activity

Add development information to the documentation #123

Merged
dan1d merged 3 commits from update-development-docs into master 2018-05-23 15:09:57 +02:00
Conversation 6 Commits 3 Files changed 1 +10
dan1d commented 2018-05-12 02:33:45 +02:00 (Migrated from github.com)
Copy link

This update to the docs will help future contributors to get the development environment ready to code, as I needed these steps clarified on discord.

This update to the docs will help future contributors to get the development environment ready to code, as I needed these steps clarified on discord.
tzarebczan commented 2018-05-14 23:44:58 +02:00 (Migrated from github.com)
Copy link

Thanks for updating this @dan1d ! "shake it device violently until you see the React Native dev menu" - awesome feature lol

@akinwale please review at your earliest convenience.

Thanks for updating this @dan1d ! "shake it device violently until you see the React Native dev menu" - awesome feature lol @akinwale please review at your earliest convenience.
😆 1
akinwale (Migrated from github.com) requested changes 2018-05-15 19:55:14 +02:00
akinwale (Migrated from github.com) left a comment
Copy link

Just a couple grammar fixes:

  • shake the device violently
  • Native Java code needs to be re-deployed using
Just a couple grammar fixes: - `shake the device violently` - `Native Java code needs to be re-deployed using`
dan1d commented 2018-05-16 01:33:07 +02:00 (Migrated from github.com)
Copy link

Thanks @akinwale, I didn't noticed these two mistakes
Let me know if I solved the issue.

Thanks @akinwale, I didn't noticed these two mistakes Let me know if I solved the issue.
akinwale (Migrated from github.com) requested changes 2018-05-16 08:22:49 +02:00
akinwale (Migrated from github.com) left a comment
Copy link

You can remove this phrase: "Hot Reloading" is not working at the moment, since this has been tested to work.

You can remove this phrase: `"Hot Reloading" is not working at the moment`, since this has been tested to work.
dan1d commented 2018-05-18 19:25:15 +02:00 (Migrated from github.com)
Copy link

Hi @akinwale I'll update the text soon, I've tested HMR the other day and It didn't work for me and an exception was thrown(HMR module is missing or something like that If I recall correctly), I'll double check this issue this weekend and update this PR.

Hi @akinwale I'll update the text soon, I've tested HMR the other day and It didn't work for me and an exception was thrown(HMR module is missing or something like that If I recall correctly), I'll double check this issue this weekend and update this PR.
tzarebczan commented 2018-05-23 04:16:53 +02:00 (Migrated from github.com)
Copy link

@dan1d friendly reminder :)

@dan1d friendly reminder :)
👍 1
dan1d commented 2018-05-23 04:22:07 +02:00 (Migrated from github.com)
Copy link

@tzarebczan i'll update the text at EOD. Finishing a PR now 👍

@tzarebczan i'll update the text at EOD. Finishing a PR now :+1:
dan1d commented 2018-05-23 04:51:25 +02:00 (Migrated from github.com)
Copy link

Hmm, I've re-tested Hot Reloading but this time worked for me, I'm very sure that I've saw a console output that said something along the lines of "hmr is not active", I will keep an eye if I see that exception again, It is working for me currently so I've updated the docs.
@akinwale @tzarebczan

Hmm, I've re-tested Hot Reloading but this time worked for me, I'm very sure that I've saw a console output that said something along the lines of "hmr is not active", I will keep an eye if I see that exception again, It is working for me currently so I've updated the docs. @akinwale @tzarebczan
👍 1
skhameneh (Migrated from github.com) approved these changes 2018-05-23 07:49:52 +02:00
akinwale (Migrated from github.com) approved these changes 2018-05-23 15:09:00 +02:00
akinwale (Migrated from github.com) left a comment
Copy link

Looks good. Thanks.

Looks good. Thanks.
Sign in to join this conversation.
Reviewers
No reviewers
skhameneh
akinwale
Labels
Clear labels   
android: closed alpha

   
android: open beta

   
app-parity

   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
creator

   
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
product review

   
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
android: closed alpha
android: open beta
app-parity
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
creator
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
product review
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#123
No description provided.
Delete branch "update-development-docs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?