hide navigation bar in fullscreen playback mode #214

2018-07-29T10:15:16+02:00

akinwale commented

2018-07-29 10:15:16 +02:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2018-07-29 10:15:16 +02:00

skhameneh (Migrated from github.com) approved these changes 2018-07-30 22:19:36 +02:00

skhameneh (Migrated from github.com) left a comment

Minor comments

src/main/java/io/lbry/browser/reactmodules/UtilityModule.java

					
				@ -50,0 +45,4 @@

				                @Override

				                public void run() {

				                    activity.getWindow().clearFlags(WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON);

				                }

skhameneh (Migrated from github.com) commented

2018-07-30 22:17:52 +02:00

Might want to check your indentation settings

src/main/java/io/lbry/browser/reactmodules/UtilityModule.java

skhameneh (Migrated from github.com) commented

2018-07-30 22:19:27 +02:00

You don't have all the same flags as listed above.
Does this still reset SYSTEM_UI_FLAG_HIDE_NAVIGATION and SYSTEM_UI_FLAG_IMMERSIVE?

You don't have all the same flags as listed above. Does this still reset `SYSTEM_UI_FLAG_HIDE_NAVIGATION` and `SYSTEM_UI_FLAG_IMMERSIVE`?

akinwale (Migrated from github.com) reviewed 2018-07-31 16:22:06 +02:00

src/main/java/io/lbry/browser/reactmodules/UtilityModule.java

akinwale (Migrated from github.com) commented

2018-07-31 16:22:06 +02:00

Yes, it resets both flags.

akinwale (Migrated from github.com) reviewed 2018-07-31 16:23:00 +02:00

src/main/java/io/lbry/browser/reactmodules/UtilityModule.java

					
				@ -50,0 +45,4 @@

				                @Override

				                public void run() {

				                    activity.getWindow().clearFlags(WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON);

				                }

akinwale (Migrated from github.com) commented

2018-07-31 16:23:00 +02:00

This a community contributed file which was using a 2-space per tab indentation. The other Java source files make use of 4 spaces, so I had to update these lines.

Sign in to join this conversation.

No reviewers

neb-b

skhameneh