Daemon 0.21 updates #223

Merged
akinwale merged 5 commits from daemon-components into master 2018-08-13 08:12:14 +02:00
akinwale commented 2018-08-08 23:41:17 +02:00 (Migrated from github.com)
No description provided.
skhameneh (Migrated from github.com) reviewed 2018-08-08 23:41:17 +02:00
eukreign (Migrated from github.com) approved these changes 2018-08-09 23:56:51 +02:00
eukreign (Migrated from github.com) left a comment

See comment, otherwise this looks good. Approved.

See comment, otherwise this looks good. Approved.
eukreign (Migrated from github.com) commented 2018-08-09 23:56:02 +02:00

Would be better to use the constants for these strings in case we change them and that way it'll fail fast (NameError) instead of more complicated errors coming from component manager.

d4a7dbf805/lbrynet/daemon/Components.py (L35-L48)

Would be better to use the constants for these strings in case we change them and that way it'll fail fast (`NameError`) instead of more complicated errors coming from component manager. https://github.com/lbryio/lbry/blob/d4a7dbf80576b3d354198496d966f36ca1d0b78a/lbrynet/daemon/Components.py#L35-L48
shyba (Migrated from github.com) approved these changes 2018-08-10 22:31:34 +02:00
neb-b (Migrated from github.com) reviewed 2018-08-13 04:54:01 +02:00
neb-b (Migrated from github.com) left a comment

One question.

One question.
@ -88,37 +89,33 @@ class SplashScreen extends React.PureComponent {
return;
neb-b (Migrated from github.com) commented 2018-08-13 04:53:00 +02:00

Aren't the headers not downloaded at this point?
blockchainHeaders.download_progress < 100
Then didDownloadHeaders is set to true

Aren't the headers not downloaded at this point? `blockchainHeaders.download_progress < 100` Then `didDownloadHeaders` is set to `true`
akinwale (Migrated from github.com) reviewed 2018-08-13 07:31:08 +02:00
@ -88,37 +89,33 @@ class SplashScreen extends React.PureComponent {
return;
akinwale (Migrated from github.com) commented 2018-08-13 07:31:08 +02:00

I'm supposed to remove this setState call as it's not needed anymore. The check is also supposed to be if (blockchainHeaders && blockchainHeaders.downloading_headers).

I'm supposed to remove this `setState` call as it's not needed anymore. The check is also supposed to be `if (blockchainHeaders && blockchainHeaders.downloading_headers)`.
neb-b (Migrated from github.com) approved these changes 2018-08-13 07:43:07 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#223
No description provided.