Daemon 0.21 updates #223
Labels
No labels
android: closed alpha
android: open beta
app-parity
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
creator
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
product review
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-android#223
Loading…
Reference in a new issue
No description provided.
Delete branch "daemon-components"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
See comment, otherwise this looks good. Approved.
Would be better to use the constants for these strings in case we change them and that way it'll fail fast (
NameError
) instead of more complicated errors coming from component manager.d4a7dbf805/lbrynet/daemon/Components.py (L35-L48)
One question.
@ -88,37 +89,33 @@ class SplashScreen extends React.PureComponent {
return;
Aren't the headers not downloaded at this point?
blockchainHeaders.download_progress < 100
Then
didDownloadHeaders
is set totrue
@ -88,37 +89,33 @@ class SplashScreen extends React.PureComponent {
return;
I'm supposed to remove this
setState
call as it's not needed anymore. The check is also supposed to beif (blockchainHeaders && blockchainHeaders.downloading_headers)
.