delete individual blob files for completed file downloads to save space #234

2018-08-15T23:30:31+02:00

akinwale commented

2018-08-15 23:30:31 +02:00

(Migrated from github.com)

Solution to save space until the "no blobs" feature is implemented on the daemon.

skhameneh (Migrated from github.com) approved these changes 2018-08-17 17:09:46 +02:00

app/src/component/AppNavigator.js

					
				@ -27,6 +27,7 @@ import {

				  TextInput,

				  ToastAndroid

				} from 'react-native';

				import { doDeleteCompleteBlobs } from '../redux/actions/file';

skhameneh (Migrated from github.com) commented

2018-08-17 17:08:10 +02:00

Replace the relative path with an alias or a build resolve

app/src/constants.js

					
				@ -8,3 +8,4 @@

				  ACTION_FIRST_RUN_PAGE_CHANGED: "FIRST_RUN_PAGE_CHANGED",

				};

				export default Constants;

skhameneh (Migrated from github.com) commented

2018-08-17 17:08:54 +02:00

Why are some still mixed formatted? (camel vs underscores)

app/src/page/splash/index.js

skhameneh (Migrated from github.com) commented

2018-08-17 17:09:00 +02:00

Replace the relative path with an alias or a build resolve

app/src/redux/actions/file.js

					
				@ -10,6 +10,7 @@ import {

				    selectDownloadingByOutpoint,

				} from 'lbry-redux';

				import { Alert, NativeModules } from 'react-native';

				import Constants from '../../constants';

skhameneh (Migrated from github.com) commented

2018-08-17 17:09:12 +02:00

Replace the relative path with an alias or a build resolve

neb-b (Migrated from github.com) approved these changes 2018-08-17 17:13:38 +02:00

akinwale (Migrated from github.com) reviewed 2018-08-17 17:20:43 +02:00

app/src/constants.js

					
				@ -8,3 +8,4 @@

				  ACTION_FIRST_RUN_PAGE_CHANGED: "FIRST_RUN_PAGE_CHANGED",

				};

				export default Constants;

akinwale (Migrated from github.com) commented

2018-08-17 17:20:42 +02:00

Following convention with the constants defined in lbry-desktop and lbry-redux. The settings and keys are mixed case. The redux actions are uppercase with underscores.
https://github.com/lbryio/lbry-redux/blob/master/src/constants/action_types.js
https://github.com/lbryio/lbry-redux/blob/master/src/constants/settings.js

Following convention with the constants defined in `lbry-desktop` and `lbry-redux`. The settings and keys are mixed case. The redux actions are uppercase with underscores. https://github.com/lbryio/lbry-redux/blob/master/src/constants/action_types.js https://github.com/lbryio/lbry-redux/blob/master/src/constants/settings.js

Sign in to join this conversation.

No reviewers

skhameneh

neb-b