Mobile rewards #251

2018-08-22T14:27:44+02:00

akinwale commented

2018-08-22 14:27:44 +02:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2018-08-22 14:27:44 +02:00

skhameneh (Migrated from github.com) requested changes 2018-08-28 00:40:55 +02:00

app/src/component/deviceIdRewardSubcard/view.js

skhameneh (Migrated from github.com) commented

2018-08-28 00:33:42 +02:00

Adjust formatting, I'd suggest:

        <Button
          style={rewardStyle.actionButton}
          text={"Allow Access"}
          onPress={this.onAllowAccessPressed}
        />

Adjust formatting, I'd suggest: ``` <Button style={rewardStyle.actionButton} text={"Allow Access"} onPress={this.onAllowAccessPressed} /> ```

app/src/component/emailRewardSubcard/view.js

					
				@ -0,0 +32,4 @@

				    });

				  }

				  componentWillReceiveProps(nextProps) {

skhameneh (Migrated from github.com) commented

2018-08-28 00:37:29 +02:00

No more legacy methods!
https://github.com/lbryio/lbry-android/pull/232/files#r210515192

No more legacy methods! https://github.com/lbryio/lbry-android/pull/232/files#r210515192

skhameneh (Migrated from github.com) commented

2018-08-28 00:39:51 +02:00

See the big yellow box:
https://reactjs.org/docs/react-component.html#updating

See the big yellow box: https://reactjs.org/docs/react-component.html#updating

app/src/component/rewardCard/view.js

					
				@ -0,0 +25,4 @@

				    claimStarted: false

				  };

				  componentWillReceiveProps(nextProps) {

skhameneh (Migrated from github.com) commented

2018-08-28 00:40:21 +02:00

https://reactjs.org/docs/react-component.html#updating

app/src/page/rewards/view.js

					
				@ -0,0 +48,4 @@

				    DeviceEventEmitter.removeListener('onPhoneStatePermissionGranted', this.phoneStatePermissionGranted);

				  }

				  componentWillReceiveProps(nextProps) {

skhameneh (Migrated from github.com) commented

2018-08-28 00:40:43 +02:00

https://reactjs.org/docs/react-component.html#updating

akinwale (Migrated from github.com) reviewed 2018-08-28 08:01:43 +02:00

app/src/component/emailRewardSubcard/view.js

					
				@ -0,0 +32,4 @@

				    });

				  }

				  componentWillReceiveProps(nextProps) {

akinwale (Migrated from github.com) commented

2018-08-28 08:01:43 +02:00

Heh! The reason I haven't moved on from this yet is we're still using an older React version, 16.2.0. I've read the documentation and it looks like the warnings started appearing from v16.3.0. I haven't had the chance to explore upgrading to newer versions of react yet (there were some issues the last time I tried), but I would love to discard all legacy methods when the time comes.

Sign in to join this conversation.

No reviewers

neb-b

skhameneh