LBRYCommunity/lbry-android
1
0
Fork 0
Code Issues 155 Pull requests 6 Projects Releases 84 Packages Wiki Activity

create navigation button component and handle onPress events properly #267

Merged
akinwale merged 1 commit from back-navigation-part-deux into master 2018-08-30 15:38:47 +02:00
Conversation 0 Commits 1 Files changed 6 +51 -10
akinwale commented 2018-08-29 22:22:56 +02:00 (Migrated from github.com)
Copy link
No description provided.
skhameneh (Migrated from github.com) reviewed 2018-08-29 22:22:56 +02:00
neb-b (Migrated from github.com) approved these changes 2018-08-30 15:08:46 +02:00
app/src/styles/discover.js
@ -84,2 +88,3 @@
marginLeft: 16
marginLeft: 16,
marginRight: 16
},
neb-b (Migrated from github.com) commented 2018-08-30 15:08:41 +02:00
Copy link

Should this be padding so the touch area is bigger?

Should this be `padding` so the touch area is bigger?
akinwale (Migrated from github.com) reviewed 2018-08-30 15:38:32 +02:00
app/src/styles/discover.js
@ -84,2 +88,3 @@
marginLeft: 16
marginLeft: 16,
marginRight: 16
},
akinwale (Migrated from github.com) commented 2018-08-30 15:38:32 +02:00
Copy link

This sets the margin on the icon (which is sort of a text element) itself. The alternative would be to apply padding to the container element.

This sets the margin on the icon (which is sort of a text element) itself. The alternative would be to apply padding to the container element.
neb-b (Migrated from github.com) reviewed 2018-08-30 19:06:31 +02:00
app/src/styles/discover.js
@ -84,2 +88,3 @@
marginLeft: 16
marginLeft: 16,
marginRight: 16
},
neb-b (Migrated from github.com) commented 2018-08-30 19:06:31 +02:00
Copy link

Ah right 👍

Ah right 👍
Sign in to join this conversation.
Reviewers
No reviewers
skhameneh
neb-b
Labels
Clear labels   
android: closed alpha

   
android: open beta

   
app-parity

   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
creator

   
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
product review

   
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
android: closed alpha
android: open beta
app-parity
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
creator
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
product review
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#267
No description provided.
Delete branch "back-navigation-part-deux"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?