add storage stats card to My LBRY downloads page #278

2018-09-02T12:20:20+02:00

akinwale commented

2018-09-02 12:20:20 +02:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2018-09-02 12:20:20 +02:00

skhameneh (Migrated from github.com) approved these changes 2018-09-03 02:14:58 +02:00

skhameneh (Migrated from github.com) left a comment

Mostly minor.
Could probably use more helper functions with some of the repeat code I see.

Mostly minor. Could probably use more helper functions with some of the repeat code I see.

app/src/component/storageStatsCard/view.js

					
				@ -0,0 +8,4 @@

				  TouchableOpacity,

				  View

				} from 'react-native';

				import { formatBytes } from '../../utils/helper';

skhameneh (Migrated from github.com) commented

2018-09-03 02:10:55 +02:00

We really need to get aliases or resolves added to remove these.
I die a little inside every time I see these crazy paths, assign an issue to me if you need me to work on this.

We really need to get aliases or resolves added to remove these. I die a little inside every time I see these crazy paths, assign an issue to me if you need me to work on this.

app/src/utils/helper.js

					
				@ -14,0 +4,4 @@

				  const params = { uri };

				  if (nav && nav.routes && nav.routes.length > 0 && 'Main' === nav.routes[0].routeName) {

				    const mainRoute = nav.routes[0];

				    const discoverRoute = mainRoute.routes[0];

skhameneh (Migrated from github.com) commented

2018-09-03 02:13:23 +02:00

Can you add more helper methods for detecting the state of routes?
This is a lot of fragile code that can quickly become unmanageable.

Can you add more helper methods for detecting the state of routes? This is a lot of fragile code that can quickly become unmanageable.

app/src/utils/helper.js

					
				@ -41,0 +37,4 @@

				  const value = (bytes / (1024.0 * 1024.0 * 1024.0)).toFixed(decimalPoints);

				  return `${value} GB`;

				}

skhameneh (Migrated from github.com) commented

2018-09-03 02:14:15 +02:00

Can define constants for a lot of these that are reused.

akinwale (Migrated from github.com) reviewed 2018-09-03 03:59:27 +02:00

app/src/component/storageStatsCard/view.js

					
				@ -0,0 +8,4 @@

				  TouchableOpacity,

				  View

				} from 'react-native';

				import { formatBytes } from '../../utils/helper';

akinwale (Migrated from github.com) commented

2018-09-03 03:59:27 +02:00

I plan to sort this out later. I just haven't taken the time to figure out how to do this yet.

Sign in to join this conversation.

No reviewers

neb-b

skhameneh

No labels

android: closed alpha

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#278

Rows
Columns