Python 3 asyncio selectors fix #344

2018-10-28T18:07:52+01:00

akinwale commented

2018-10-28 18:07:52 +01:00

(Migrated from github.com)

No description provided.

shyba (Migrated from github.com) reviewed 2018-10-28 18:07:52 +01:00

eukreign (Migrated from github.com) approved these changes 2018-10-28 18:57:21 +01:00

eukreign (Migrated from github.com) left a comment

Seems good to me, just had one suggestion:

src/main/python/lbrynetservice.py

					
				@ -1,10 +1,24 @@

				import sys

				from twisted.internet import asyncioreactor

				if 'twisted.internet.reactor' not in sys.modules:

				    asyncioreactor.install()

eukreign (Migrated from github.com) commented

2018-10-28 18:44:36 +01:00

This might lead to confusing results if the wrong reactor was installed previously. I think it would better to either 1) just asyncioreactor.install() without putting it inside of a conditional or, alternately, 2) add an else to the existing condition which checks that the reactor installed previously is in fact an asyncioreactor.

This might lead to confusing results if the wrong reactor was installed previously. I think it would better to either 1) just `asyncioreactor.install()` without putting it inside of a conditional or, alternately, 2) add an `else` to the existing condition which checks that the reactor installed previously is in fact an `asyncioreactor`.

Sign in to join this conversation.

No reviewers

shyba

eukreign