Custom reward codes #374

Merged
akinwale merged 2 commits from custom-reward-codes into master 2018-12-12 19:45:44 +01:00
akinwale commented 2018-12-11 20:22:30 +01:00 (Migrated from github.com)

Added the custom reward code card and the ability to redeem codes.

Added the custom reward code card and the ability to redeem codes.
skhameneh (Migrated from github.com) approved these changes 2018-12-11 20:31:32 +01:00
@ -0,0 +1,83 @@
// @flow
import React from 'react';
import { ActivityIndicator, Text, TextInput, TouchableOpacity, View } from 'react-native';
import Colors from '../../styles/colors';
skhameneh (Migrated from github.com) commented 2018-12-11 20:25:38 +01:00

Have you looked at using aliases for these through babel?

This would be ideal since we can use it across all apps:
https://www.npmjs.com/package/babel-plugin-webpack-aliases

And here's an alternative that isn't opinionated towards how Webpack does things:
https://www.npmjs.com/package/babel-plugin-module-resolver

Have you looked at using aliases for these through babel? This would be ideal since we can use it across all apps: https://www.npmjs.com/package/babel-plugin-webpack-aliases And here's an alternative that isn't opinionated towards how Webpack does things: https://www.npmjs.com/package/babel-plugin-module-resolver
@ -0,0 +17,4 @@
const { error, rewardIsPending } = nextProps;
const { clearError, notify } = this.props;
if (this.state.claimStarted && !rewardIsPending) {
if (error && error.trim().length > 0) {
skhameneh (Migrated from github.com) commented 2018-12-11 20:26:46 +01:00

We get whitespace errors?
This seems like something that should be cleaned up at the source

We get whitespace errors? This seems like something that should be cleaned up at the source
akinwale (Migrated from github.com) reviewed 2018-12-12 19:45:29 +01:00
@ -0,0 +1,83 @@
// @flow
import React from 'react';
import { ActivityIndicator, Text, TextInput, TouchableOpacity, View } from 'react-native';
import Colors from '../../styles/colors';
akinwale (Migrated from github.com) commented 2018-12-12 19:45:29 +01:00

I'll look into this.

I'll look into this.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#374
No description provided.