LBRYCommunity/lbry-android
1
0
Fork 0
Code Issues 155 Pull requests 6 Projects Releases 84 Packages Wiki Activity

Mobile subscriptions #382

Merged
akinwale merged 5 commits from subscriptions into master 2019-01-07 08:26:47 +01:00
Conversation 3 Commits 5 Files changed 18 +414 -28
akinwale commented 2018-12-28 14:28:34 +01:00 (Migrated from github.com)
Copy link
No description provided.
neb-b (Migrated from github.com) reviewed 2018-12-28 14:28:34 +01:00
skhameneh (Migrated from github.com) reviewed 2019-01-03 02:24:42 +01:00
skhameneh (Migrated from github.com) left a comment
Copy link

Please add aliases

Please add aliases
app/src/index.js
skhameneh (Migrated from github.com) commented 2019-01-03 02:23:17 +01:00
Copy link

Remove?

Remove?
app/src/page/subscriptions/view.js
skhameneh (Migrated from github.com) commented 2019-01-03 02:24:22 +01:00
Copy link

You should know what I'm going to say by now, comes up every review. More than one level up a relative path is fragile, please add aliases.

You should know what I'm going to say by now, comes up every review. More than one level up a relative path is fragile, please add aliases.
akinwale (Migrated from github.com) reviewed 2019-01-04 15:20:34 +01:00
app/src/page/subscriptions/view.js
akinwale (Migrated from github.com) commented 2019-01-04 15:20:34 +01:00
Copy link

Finally added module-resolver to .babelrc to sort this out..

Finally added module-resolver to `.babelrc` to sort this out..
akinwale (Migrated from github.com) reviewed 2019-01-04 15:20:52 +01:00
app/src/index.js
akinwale (Migrated from github.com) commented 2019-01-04 15:20:52 +01:00
Copy link

Yes.

Yes.
tzarebczan commented 2019-01-05 01:08:28 +01:00 (Migrated from github.com)
Copy link

On first load, it took some time for the subs to show up. Can we add a loading icon?

Should we have 2 different views similar to the desktop app? Right now it looks like it's by creator, then date..so I don't see the latest content on top.

On first load, it took some time for the subs to show up. Can we add a loading icon? Should we have 2 different views similar to the desktop app? Right now it looks like it's by creator, then date..so I don't see the latest content on top.
skhameneh (Migrated from github.com) reviewed 2019-01-05 03:02:22 +01:00
app/package.json
@ -7,8 +7,9 @@
},
"dependencies": {
"base-64": "^0.1.0",
"@expo/vector-icons": "^8.1.0",
skhameneh (Migrated from github.com) commented 2019-01-05 03:02:22 +01:00
Copy link

How does this compare to react-native-vector-icons?

How does this compare to [react-native-vector-icons](https://www.npmjs.com/package/react-native-vector-icons)?
skhameneh (Migrated from github.com) approved these changes 2019-01-05 03:06:27 +01:00
app/src/component/AppNavigator.js
skhameneh (Migrated from github.com) commented 2019-01-05 03:03:06 +01:00
Copy link

Line breaks before and check indentation above

Line breaks before and check indentation above
app/src/component/button/view.js
@ -46,3 +53,3 @@
{icon && <Icon name={icon} size={18} color={'light' === theme ? Colors.DarkGrey : Colors.White} />}
{icon && renderIcon}
{text && (text.trim().length > 0) && <Text style={textStyles}>{text}</Text>}
</TouchableOpacity>
skhameneh (Migrated from github.com) commented 2019-01-05 03:04:53 +01:00
Copy link
const renderIcon = (
  <Icon name={icon} size={18} color={iconColor ? iconColor : ('light' === theme ? Colors.DarkGrey : Colors.White)} solid={!!solid} />
);
``` const renderIcon = ( <Icon name={icon} size={18} color={iconColor ? iconColor : ('light' === theme ? Colors.DarkGrey : Colors.White)} solid={!!solid} /> ); ```
skhameneh commented 2019-01-05 03:06:53 +01:00 (Migrated from github.com)
Copy link

Assign back if you need new changes reviewed

Assign back if you need new changes reviewed
akinwale (Migrated from github.com) reviewed 2019-01-07 08:25:56 +01:00
app/package.json
@ -7,8 +7,9 @@
},
"dependencies": {
"base-64": "^0.1.0",
"@expo/vector-icons": "^8.1.0",
akinwale (Migrated from github.com) commented 2019-01-07 08:25:55 +01:00
Copy link

For some reason, it was showing up as a missing dependency after I added the .babelrc. Adding the package solves this.

For some reason, it was showing up as a missing dependency after I added the `.babelrc`. Adding the package solves this.
akinwale commented 2019-01-07 08:50:43 +01:00 (Migrated from github.com)
Copy link

@tzarebczan We can do that for a future release. Although, I'd like to make the default order date published so that the latest content shows up at the top.

@tzarebczan We can do that for a future release. Although, I'd like to make the default order date published so that the latest content shows up at the top.
Sign in to join this conversation.
Reviewers
No reviewers
neb-b
skhameneh
Labels
Clear labels   
android: closed alpha

   
android: open beta

   
app-parity

   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
creator

   
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
product review

   
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
android: closed alpha
android: open beta
app-parity
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
creator
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
product review
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#382
No description provided.
Delete branch "subscriptions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?