better back button navigation handling #408

2019-01-19T19:35:41+01:00

akinwale commented

2019-01-19 19:35:41 +01:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2019-01-19 19:35:41 +01:00

skhameneh (Migrated from github.com) approved these changes 2019-01-21 06:51:20 +01:00

app/src/redux/reducers/drawer.js

					
				@ -0,0 +7,4 @@

				reducers[Constants.ACTION_PUSH_DRAWER_STACK] = (state, action) => {

				  const routeName = action.data;

				  const newStack = state.stack.slice();

skhameneh (Migrated from github.com) commented

2019-01-21 06:50:01 +01:00

Immutable.js can make this easier & more efficient

app/src/utils/helper.js

skhameneh (Migrated from github.com) commented

2019-01-21 06:51:04 +01:00

Can you split this like:

  const shouldPopStack = (
    (drawerRouteIndex > 0 && drawerRouteIndex !== 5) || // not the discover nor wallet stack
    (drawerRouteIndex === 5 && nav.routes[0].routes[drawerRouteIndex].index === 0); // wallet stack, and tx history page not active
  );

Can you split this like: ``` const shouldPopStack = ( (drawerRouteIndex > 0 && drawerRouteIndex !== 5) || // not the discover nor wallet stack (drawerRouteIndex === 5 && nav.routes[0].routes[drawerRouteIndex].index === 0); // wallet stack, and tx history page not active ); ```

Sign in to join this conversation.

No reviewers

neb-b

skhameneh